New issue
Advanced search Search tips

Issue 895512 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::RuleFeatureSet::Add

Project Member Reported by ClusterFuzz, Oct 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6283100567633920

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000168
Crash State:
  blink::RuleFeatureSet::Add
  blink::StyleEngine::CollectFeaturesTo
  blink::Document::UpdateActiveStyle
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=597424:597425

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6283100567633920

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 15

Components: Blink>CSS Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 15

Labels: Test-Predator-Auto-Owner
Owner: rakina@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/b062ae3753f451a573e32c85ebffd8df212d19ab (Make custom element default style accept array of stylesheets).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
rakina@ have you had a chance to look at this?
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8954050618f676f94d9f80172cd8355abe2e8c91

commit 8954050618f676f94d9f80172cd8355abe2e8c91
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Nov 21 10:42:32 2018

Only handle CE default styles that have rule sets

Some CE default styles might not have RuleSets, this CL adds some
null checks.

Bug:  895512 

Change-Id: I02e0f5070c36c72e8d03ed950d96783506f05c5a
Reviewed-on: https://chromium-review.googlesource.com/c/1343585
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609990}
[modify] https://crrev.com/8954050618f676f94d9f80172cd8355abe2e8c91/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify] https://crrev.com/8954050618f676f94d9f80172cd8355abe2e8c91/third_party/blink/renderer/core/css/style_engine.h

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Nov 22

ClusterFuzz has detected this issue as fixed in range 609989:609991.

Detailed report: https://clusterfuzz.com/testcase?key=6283100567633920

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000168
Crash State:
  blink::RuleFeatureSet::Add
  blink::StyleEngine::CollectFeaturesTo
  blink::Document::UpdateActiveStyle
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=597424:597425
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=609989:609991

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6283100567633920

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 22

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6283100567633920 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment