New issue
Advanced search Search tips

Issue 895500 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 829522



Sign in to add a comment

Implement factorybranch builders.

Project Member Reported by dgarr...@chromium.org, Oct 15

Issue description

To migrate factory builds to swarming, we need to implement a TOT builder for factory builds which is similar to "firmwarebranch" builds. Since factory builds are more complex, this will be a much harder problem.
 
Blocking: 829522
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c281275a4ce0cc08909d42958cc4fb9aef107fa8

commit c281275a4ce0cc08909d42958cc4fb9aef107fa8
Author: Don Garrett <dgarrett@google.com>
Date: Thu Nov 01 16:58:13 2018

chromeos_config: Create placeholder prototype-factorybranch build.

Create a new build config to use as the basis of development for
factorybranch builders. It's non-functional, but makes it feasible to
test future changes.

BUG=chromium:895500
TEST=None

Change-Id: I3fe44b3f4cd07c3eda4e667cad009359a5dc51b1
Reviewed-on: https://chromium-review.googlesource.com/c/1302894
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/c281275a4ce0cc08909d42958cc4fb9aef107fa8/config/chromeos_config.py
[modify] https://crrev.com/c281275a4ce0cc08909d42958cc4fb9aef107fa8/config/waterfall_layout_dump.txt
[modify] https://crrev.com/c281275a4ce0cc08909d42958cc4fb9aef107fa8/cbuildbot/builders/workspace_builders.py
[modify] https://crrev.com/c281275a4ce0cc08909d42958cc4fb9aef107fa8/config/config_dump.json

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1c7fe66bc65f08ae00f9b641900e35e43c1591de

commit 1c7fe66bc65f08ae00f9b641900e35e43c1591de
Author: Don Garrett <dgarrett@google.com>
Date: Thu Nov 01 18:10:10 2018

chromeos_config: Create factorybranch configs for existing branches.

Copy the list of factory branches / boards from the existing waterfall
configuration. None of these builds are scheduled, or even close to
being ready for production use.

BUG=chromium:895500
TEST=None

Change-Id: I9277892105964f086c37531f8f05ac05f36fc5ad
Reviewed-on: https://chromium-review.googlesource.com/1310694
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>

[modify] https://crrev.com/1c7fe66bc65f08ae00f9b641900e35e43c1591de/config/chromeos_config.py
[modify] https://crrev.com/1c7fe66bc65f08ae00f9b641900e35e43c1591de/config/waterfall_layout_dump.txt
[modify] https://crrev.com/1c7fe66bc65f08ae00f9b641900e35e43c1591de/config/config_dump.json

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bf8e0e6e82855c65906345d3f7871acc72dcfa38

commit bf8e0e6e82855c65906345d3f7871acc72dcfa38
Author: Don Garrett <dgarrett@google.com>
Date: Wed Dec 19 05:33:26 2018

workspace_stages: Create WorkspaceSyncChrome stage.

Create a new stage that syncs Chrome source code based on the version
needed in the workspace checkout.

BUG=chromium:895500
TEST=cros tryjob --cbuildbot prototype-factorybranch-tryjob
       --pass-through="--workspace=<dir>"

Change-Id: I998309521a3b717b12c7c3499a9bf0acc4159990
Reviewed-on: https://chromium-review.googlesource.com/1382933
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/bf8e0e6e82855c65906345d3f7871acc72dcfa38/cbuildbot/stages/workspace_stages.py
[modify] https://crrev.com/bf8e0e6e82855c65906345d3f7871acc72dcfa38/cbuildbot/builders/workspace_builders.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/60c7c53c6a24bd4bc063d76345e5a3cffc84d0a8

commit 60c7c53c6a24bd4bc063d76345e5a3cffc84d0a8
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jan 15 02:18:29 2019

chromeos_config: Move factorybranch to buildspecs.

Revise the factorybranch builders to use a per-branch buildspec
builder, and a per-board factorybranch builder. Since these builds are
not yet live, this has no real impact.

This is required, because the buildtime for a factorybranch build is
too long to support cycling over every board on a branch within the
allotted timeline.

BUG=chromium:895500
TEST=run_tests

Change-Id: I136e7b3aa7e25f3b3f010debea63e4bc691a9d19
Reviewed-on: https://chromium-review.googlesource.com/1410161
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>

[modify] https://crrev.com/60c7c53c6a24bd4bc063d76345e5a3cffc84d0a8/config/chromeos_config.py
[modify] https://crrev.com/60c7c53c6a24bd4bc063d76345e5a3cffc84d0a8/config/waterfall_layout_dump.txt
[modify] https://crrev.com/60c7c53c6a24bd4bc063d76345e5a3cffc84d0a8/config/config_dump.json

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/09aafe6fb6c6efe07e1989bb23b20528fba3b8a5

commit 09aafe6fb6c6efe07e1989bb23b20528fba3b8a5
Author: Don Garrett <dgarrett@google.com>
Date: Wed Jan 16 03:50:16 2019

workspace_stages: Use consistent .cache dir.

Workspace stages are sometimes using .cache in the infra checkout, and
sometimes in the workspace checkout. Try to be more consistent.

BUG=chromium:895500
TEST=cros tryjob --cbuildbot prototype-factorybranch-tryjob
       --pass-through="--workspace=<dir>"

Change-Id: I68adf7c3d34f8897a7398cb2a80c9b46c1a46830
Reviewed-on: https://chromium-review.googlesource.com/1407453
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/09aafe6fb6c6efe07e1989bb23b20528fba3b8a5/cbuildbot/stages/workspace_stages.py

Project Member

Comment 7 by bugdroid1@chromium.org, Today (12 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/faf0c347d68e04521bcf0006727f212dfb4f3ccb

commit faf0c347d68e04521bcf0006727f212dfb4f3ccb
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jan 22 19:41:47 2019

workspace_builders: Add unittests for new builder classes.

Add unittest coverage for the new workspace builder classes so that we
can at least do sanity checking of changes to them without running
multi-hour test builds.

BUG=chromium:895500
TEST=./run_tests

Change-Id: I0e2f7e1446503dd5e5bc9350bae517944c6b7137
Reviewed-on: https://chromium-review.googlesource.com/c/1416410
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[add] https://crrev.com/faf0c347d68e04521bcf0006727f212dfb4f3ccb/cbuildbot/builders/workspace_builders_unittest.py
[add] https://crrev.com/faf0c347d68e04521bcf0006727f212dfb4f3ccb/cbuildbot/builders/workspace_builders_unittest

Project Member

Comment 8 by bugdroid1@chromium.org, Today (12 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/923d47ced255508bda7bd7f45bb26b8076599a41

commit 923d47ced255508bda7bd7f45bb26b8076599a41
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jan 22 19:41:56 2019

workspace_stages: Add unittests for new stage classes.

Add unittest coverage for the new workspace stage classes so that we
can at least do sanity checking of changes to them without running
multi-hour test builds.

BUG=chromium:895500
TEST=./run_tests

Change-Id: I977d4b8e09cf2d996555cc5a19fa5ed775e643dd
Reviewed-on: https://chromium-review.googlesource.com/c/1416411
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/923d47ced255508bda7bd7f45bb26b8076599a41/cbuildbot/stages/workspace_stages.py
[add] https://crrev.com/923d47ced255508bda7bd7f45bb26b8076599a41/cbuildbot/stages/workspace_stages_unittest.py
[modify] https://crrev.com/923d47ced255508bda7bd7f45bb26b8076599a41/cbuildbot/stages/generic_stages_unittest.py
[add] https://crrev.com/923d47ced255508bda7bd7f45bb26b8076599a41/cbuildbot/stages/workspace_stages_unittest

Sign in to add a comment