New issue
Advanced search Search tips

Issue 895498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 851152

Blocking:
issue 834068
issue 834070



Sign in to add a comment

Migrate CQ builders (paladins) to swarming

Project Member Reported by dgarr...@chromium.org, Oct 15

Issue description

The CQ builders should be migrated to swarming.
 
Blocking: 834068 834070
Blockedon: 851152
The working plan is to grow the current affinity pool by 10 builders, then migrate a single (experimental) CQ slave over to see what happens.

If that works, we'll start migrating more and more slaves over.

The master-paladin builder will be migrated last. It does not require affinity, but is a risky migration.

I'm predicting problems (somewhere) because of the removal of the builder_run number.
Cc: mikenichols@chromium.org athilenius@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d3e14a443d59101a3598ff4d29a5a971d388afd2

commit d3e14a443d59101a3598ff4d29a5a971d388afd2
Author: Don Garrett <dgarrett@google.com>
Date: Mon Oct 15 23:08:41 2018

chromeos_config: Move nyan_blaze-paladin to swarming.

Move the already experimental nyan_blaze-paladin build slave to
swarming to see what breaks.

BUG= chromium:895498 
TEST=chromeos_config_unittest

Change-Id: I1550683dff74ee903221eb5194f3a62f0701bc5a
Reviewed-on: https://chromium-review.googlesource.com/1281443
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Alec Thilenius <athilenius@google.com>

[modify] https://crrev.com/d3e14a443d59101a3598ff4d29a5a971d388afd2/config/chromeos_config.py
[modify] https://crrev.com/d3e14a443d59101a3598ff4d29a5a971d388afd2/config/waterfall_layout_dump.txt
[modify] https://crrev.com/d3e14a443d59101a3598ff4d29a5a971d388afd2/config/config_dump.json

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b708a096f473b55b8a72f4599067202d56b4f90b

commit b708a096f473b55b8a72f4599067202d56b4f90b
Author: Don Garrett <dgarrett@google.com>
Date: Tue Oct 16 15:19:40 2018

chromeos_config: Move external CQ to swarming.

This moves all CQ builders on chromiumos to swarming. This means that
non-expiremental CQ builders will be on swarming. It also means that
all chromiumos waterfall builders will have migrated.

This was done to make it easy to transfer all GCE builders from
chromiumos to the swarming pools, to increase capacity. It also
enables a shutdown of the chromiumos waterfall.

However, we may wait a day or two to ensure the new builds are really
stable bevore shutting things down.

BUG= chromium:895498 
TEST=chromeos_config + inspecting waterfall_layout_dump.txt.

Change-Id: Icc760b6da0444bcb3e5f1e7be0b71e84b73fe201
Reviewed-on: https://chromium-review.googlesource.com/1282353
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/b708a096f473b55b8a72f4599067202d56b4f90b/config/chromeos_config.py
[modify] https://crrev.com/b708a096f473b55b8a72f4599067202d56b4f90b/config/waterfall_layout_dump.txt
[modify] https://crrev.com/b708a096f473b55b8a72f4599067202d56b4f90b/config/config_dump.json

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2eee64982a09c8da44d3765313e3b42a39597c17

commit 2eee64982a09c8da44d3765313e3b42a39597c17
Author: Don Garrett <dgarrett@google.com>
Date: Wed Oct 17 00:25:09 2018

chromeos_config: Migrate more CQ builders.

Migrate additional builders that run hwtests to swarming.
  bob
  elm
  link

BUG= chromium:895498 
TEST=chromeos_config_unittest

Change-Id: Ic1effbab66522366c7630e3d04cbf75959fe9f98
Reviewed-on: https://chromium-review.googlesource.com/1284689
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/2eee64982a09c8da44d3765313e3b42a39597c17/config/chromeos_config.py
[modify] https://crrev.com/2eee64982a09c8da44d3765313e3b42a39597c17/config/waterfall_layout_dump.txt
[modify] https://crrev.com/2eee64982a09c8da44d3765313e3b42a39597c17/config/config_dump.json

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/364a0d6bd98c50464e9c3e9d93e06834c27dc84a

commit 364a0d6bd98c50464e9c3e9d93e06834c27dc84a
Author: Don Garrett <dgarrett@google.com>
Date: Thu Oct 18 17:02:23 2018

chromeos_config: Move all CQ slaves to swarming.

Move all remaining CQ slave builds over to swarming, leaving only the
master-paladin on the chromeos waterfall.

BUG= chromium:895498 
TEST=run_tests

Change-Id: I3f14154bdf3865c7a8c38680fbc7681679424589
Reviewed-on: https://chromium-review.googlesource.com/c/1289009
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/364a0d6bd98c50464e9c3e9d93e06834c27dc84a/config/chromeos_config.py
[modify] https://crrev.com/364a0d6bd98c50464e9c3e9d93e06834c27dc84a/config/waterfall_layout_dump.txt
[modify] https://crrev.com/364a0d6bd98c50464e9c3e9d93e06834c27dc84a/config/config_dump.json

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f94579d3c84cba6992e878722001fa1508770ca3

commit f94579d3c84cba6992e878722001fa1508770ca3
Author: Don Garrett <dgarrett@chromium.org>
Date: Thu Oct 18 17:33:38 2018

Revert "chromeos_config: Move all CQ slaves to swarming."

This reverts commit 364a0d6bd98c50464e9c3e9d93e06834c27dc84a.

Reason for revert: Fix lib/builder_status_lib_unittest

Original change's description:
> chromeos_config: Move all CQ slaves to swarming.
> 
> Move all remaining CQ slave builds over to swarming, leaving only the
> master-paladin on the chromeos waterfall.
> 
> BUG= chromium:895498 
> TEST=run_tests
> 
> Change-Id: I3f14154bdf3865c7a8c38680fbc7681679424589
> Reviewed-on: https://chromium-review.googlesource.com/c/1289009
> Tested-by: Don Garrett <dgarrett@chromium.org>
> Trybot-Ready: Don Garrett <dgarrett@chromium.org>
> Commit-Queue: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Mike Nichols <mikenichols@chromium.org>

Bug:  chromium:895498 
Change-Id: Iee4c14c2b57ce793def83a37c06c9b2e170136d2
Reviewed-on: https://chromium-review.googlesource.com/c/1289010
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f94579d3c84cba6992e878722001fa1508770ca3/config/chromeos_config.py
[modify] https://crrev.com/f94579d3c84cba6992e878722001fa1508770ca3/config/waterfall_layout_dump.txt
[modify] https://crrev.com/f94579d3c84cba6992e878722001fa1508770ca3/config/config_dump.json

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/842ebf89cf4dbe28c0178d1f70452606517ba34d

commit 842ebf89cf4dbe28c0178d1f70452606517ba34d
Author: Don Garrett <dgarrett@google.com>
Date: Thu Oct 18 19:03:28 2018

Reland "chromeos_config: Move all CQ slaves to swarming."

This is a reland of 364a0d6bd98c50464e9c3e9d93e06834c27dc84a

This also fixes a unittest that made assumptions about some paladin
build configs running on buildbot.

Original change's description:
> chromeos_config: Move all CQ slaves to swarming.
>
> Move all remaining CQ slave builds over to swarming, leaving only the
> master-paladin on the chromeos waterfall.
>
> BUG= chromium:895498 
> TEST=run_tests
>
> Change-Id: I3f14154bdf3865c7a8c38680fbc7681679424589
> Reviewed-on: https://chromium-review.googlesource.com/c/1289009
> Tested-by: Don Garrett <dgarrett@chromium.org>
> Trybot-Ready: Don Garrett <dgarrett@chromium.org>
> Commit-Queue: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Mike Nichols <mikenichols@chromium.org>

Bug:  chromium:895498 
Change-Id: I9271868875228dddd8af7c98bfd8069122e9b4f5
Reviewed-on: https://chromium-review.googlesource.com/c/1289011
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/842ebf89cf4dbe28c0178d1f70452606517ba34d/config/chromeos_config.py
[modify] https://crrev.com/842ebf89cf4dbe28c0178d1f70452606517ba34d/config/waterfall_layout_dump.txt
[modify] https://crrev.com/842ebf89cf4dbe28c0178d1f70452606517ba34d/config/config_dump.json
[modify] https://crrev.com/842ebf89cf4dbe28c0178d1f70452606517ba34d/lib/builder_status_lib.py
[modify] https://crrev.com/842ebf89cf4dbe28c0178d1f70452606517ba34d/lib/builder_status_lib_unittest.py

Status: Fixed (was: Started)
📣 Woohoo! 📣

Sign in to add a comment