New issue
Advanced search Search tips

Issue 895486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Resource Scheduler: Add UMA to record request queuing time

Project Member Reported by tbansal@chromium.org, Oct 15

Issue description

In Resource Scheduler, add UMA to record request queuing time broken
down by request loading priority. This would help us in understanding how long do requests stay queued before being dispatched to the network. This would also be useful to understand how different resource scheduling algorithms are affecting queuing times, and to understand cases where high priority requests are queued for too long.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e9d89741c43a0e36b4df64f250035c71943395b

commit 7e9d89741c43a0e36b4df64f250035c71943395b
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Oct 17 18:41:07 2018

Resource Scheduler: Add UMA to record request queuing time

Resource Scheduler: Add UMA to record request queuing time broken
down by request loading priority

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I120b9f0b549c76d1f36920c051014afe71462db2
Bug:  895486 
Reviewed-on: https://chromium-review.googlesource.com/c/1280145
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600493}
[modify] https://crrev.com/7e9d89741c43a0e36b4df64f250035c71943395b/services/network/resource_scheduler.cc
[modify] https://crrev.com/7e9d89741c43a0e36b4df64f250035c71943395b/services/network/resource_scheduler_unittest.cc
[modify] https://crrev.com/7e9d89741c43a0e36b4df64f250035c71943395b/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-71 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Requesting approval for CL in #1. It's pretty safe CL.
Labels: -Merge-Request-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #2.
Pls merge your change to M71 branch #3578 ASAP so we can pick it up for next M71 Beta release. Thank you.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b6db9061370257d4d97127e4575e6c68605781

commit e0b6db9061370257d4d97127e4575e6c68605781
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Oct 19 22:12:53 2018

Resource Scheduler: Add UMA to record request queuing time

Resource Scheduler: Add UMA to record request queuing time broken
down by request loading priority

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I120b9f0b549c76d1f36920c051014afe71462db2
Bug:  895486 
Reviewed-on: https://chromium-review.googlesource.com/c/1280145
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600493}(cherry picked from commit 7e9d89741c43a0e36b4df64f250035c71943395b)
Reviewed-on: https://chromium-review.googlesource.com/c/1292718
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#174}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/e0b6db9061370257d4d97127e4575e6c68605781/services/network/resource_scheduler.cc
[modify] https://crrev.com/e0b6db9061370257d4d97127e4575e6c68605781/services/network/resource_scheduler_unittest.cc
[modify] https://crrev.com/e0b6db9061370257d4d97127e4575e6c68605781/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e0b6db9061370257d4d97127e4575e6c68605781

Commit: e0b6db9061370257d4d97127e4575e6c68605781
Author: tbansal@chromium.org
Commiter: tbansal@chromium.org
Date: 2018-10-19 22:12:53 +0000 UTC

Resource Scheduler: Add UMA to record request queuing time

Resource Scheduler: Add UMA to record request queuing time broken
down by request loading priority

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I120b9f0b549c76d1f36920c051014afe71462db2
Bug:  895486 
Reviewed-on: https://chromium-review.googlesource.com/c/1280145
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600493}(cherry picked from commit 7e9d89741c43a0e36b4df64f250035c71943395b)
Reviewed-on: https://chromium-review.googlesource.com/c/1292718
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#174}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment