New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895485 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Display device language icon in explicit language ask prompt

Project Member Reported by anthonyvd@chromium.org, Oct 15

Issue description

The list should display an icon next to the language that's the current UI language.
 
Here's what the icon should look like.
Screen Shot 2018-09-26 at 12.23.44 PM.png
38.2 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f

commit f15ffdffd25adccf60f38a74da72ae67bd2b9a9f
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Oct 15 20:01:32 2018

Add the device language icon to the explicit language ask prompt

Bug:  895485 
Change-Id: I57b740831956d1ed9985aa580b7fa24e7b085f7e
Reviewed-on: https://chromium-review.googlesource.com/c/1280852
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599727}
[add] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/res/drawable-hdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/res/drawable-mdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/res/drawable-xhdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/res/drawable-xxhdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/res/drawable-xxxhdpi/ic_mobile_friendly_grey600_24dp.png
[modify] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/res/layout/language_ask_prompt_row.xml
[modify] https://crrev.com/f15ffdffd25adccf60f38a74da72ae67bd2b9a9f/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Status: Fixed (was: Started)
Labels: Merge-Request-71
Status: Started (was: Fixed)
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 26

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Cc: benmason@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca61d998d92b28737366f96f586651cb26a8b3d3

commit ca61d998d92b28737366f96f586651cb26a8b3d3
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Oct 30 13:58:44 2018

Add the device language icon to the explicit language ask prompt

Bug:  895485 
Change-Id: I57b740831956d1ed9985aa580b7fa24e7b085f7e
Reviewed-on: https://chromium-review.googlesource.com/c/1280852
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599727}(cherry picked from commit f15ffdffd25adccf60f38a74da72ae67bd2b9a9f)
Reviewed-on: https://chromium-review.googlesource.com/c/1307574
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#387}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[add] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/res/drawable-hdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/res/drawable-mdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/res/drawable-xhdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/res/drawable-xxhdpi/ic_mobile_friendly_grey600_24dp.png
[add] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/res/drawable-xxxhdpi/ic_mobile_friendly_grey600_24dp.png
[modify] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/res/layout/language_ask_prompt_row.xml
[modify] https://crrev.com/ca61d998d92b28737366f96f586651cb26a8b3d3/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ca61d998d92b28737366f96f586651cb26a8b3d3

Commit: ca61d998d92b28737366f96f586651cb26a8b3d3
Author: anthonyvd@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-30 13:58:44 +0000 UTC

Add the device language icon to the explicit language ask prompt

Bug:  895485 
Change-Id: I57b740831956d1ed9985aa580b7fa24e7b085f7e
Reviewed-on: https://chromium-review.googlesource.com/c/1280852
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599727}(cherry picked from commit f15ffdffd25adccf60f38a74da72ae67bd2b9a9f)
Reviewed-on: https://chromium-review.googlesource.com/c/1307574
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#387}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)

Sign in to add a comment