New issue
Advanced search Search tips

Issue 895463 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove ukm sampling schema from input metrics

Project Member Reported by nzolghadr@chromium.org, Oct 15

Issue description

We should deprecate our own version of sampling events from latency_tracker.cc:
https://cs.chromium.org/chromium/src/ui/latency/latency_tracker.h?sq=package:chromium&dr=C&g=0&l=57

in favor or ukm infrastructure sampling.
 
Labels: Hotlist-CodeHealth
Summary: Remove ukm sampling schema from input metrics (was: Remove ukm sampling schema from input metrcis)
Owner: nzolghadr@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f509a32b60352f85ed29950b1a24752ad14ce35e

commit f509a32b60352f85ed29950b1a24752ad14ce35e
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri Oct 19 19:00:07 2018

Remove input metric ukm sampling

We added a sampling scheme when ukm was introduced
back in the day to control the amount of data we
report to the server.
Now that there is a general mechanism for controling
the data we can remove our own version of resampling
and rely only on the dashboard team to take care of
that.

Bug: 895463
Change-Id: If23332437205aa027b77a1140f28b9492692791a
Reviewed-on: https://chromium-review.googlesource.com/c/1283941
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601247}
[modify] https://crrev.com/f509a32b60352f85ed29950b1a24752ad14ce35e/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/f509a32b60352f85ed29950b1a24752ad14ce35e/ui/latency/latency_tracker.cc
[modify] https://crrev.com/f509a32b60352f85ed29950b1a24752ad14ce35e/ui/latency/latency_tracker.h

Sign in to add a comment