New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895460 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Build-Toolchain

Blocking:
issue 834385



Sign in to add a comment

xfsprogs: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Oct 15

Issue description

with glibc 2.27

emerge-samus xfsprogs
 
xfsprogs-4.14.0-r1: copy_file_range.c:46:1: error: static declaration of 'copy_file_range' follows non-static declaration
xfsprogs-4.14.0-r1: copy_file_range(int fd, loff_t *src, loff_t *dst, size_t len)
xfsprogs-4.14.0-r1: ^
xfsprogs-4.14.0-r1: ../../../../../../../usr/include/unistd.h:1110:9: note: previous declaration is here
xfsprogs-4.14.0-r1: ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
xfsprogs-4.14.0-r1:         ^
xfsprogs-4.14.0-r1: copy_file_range.c:133:43: error: too few arguments to function call, expected 6, have 4
xfsprogs-4.14.0-r1:         ret = copy_file_range(fd, &src, &dst, len);
xfsprogs-4.14.0-r1:               ~~~~~~~~~~~~~~~                    ^

 
Blocking: 834385
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/54594c3808aeb979d6e7ab29af09acf6757ebb65

commit 54594c3808aeb979d6e7ab29af09acf6757ebb65
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Oct 16 17:30:47 2018

xfsprogs: backport upstream patch to build with glibc 2.27

This backports an upstream patch to fix build issue with glibc 2.27.
Since it is an upstream patch, I just modify it in portage-stable,
I can move it to chromiumos-overlay if needed.

BUG= chromium:895460 
TEST=emerge-samus xfsprogs with glibc 2.27

Change-Id: Ifd5e006788aaa9b80e4244d912b1fe706d3f30c8
Reviewed-on: https://chromium-review.googlesource.com/1280902
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[rename] https://crrev.com/54594c3808aeb979d6e7ab29af09acf6757ebb65/sys-fs/xfsprogs/xfsprogs-4.14.0-r2.ebuild
[add] https://crrev.com/54594c3808aeb979d6e7ab29af09acf6757ebb65/sys-fs/xfsprogs/files/xfsprogs-4.14-copy_file_rage.patch
[modify] https://crrev.com/54594c3808aeb979d6e7ab29af09acf6757ebb65/sys-fs/xfsprogs/xfsprogs-4.14.0.ebuild

Status: Verified (was: Untriaged)

Sign in to add a comment