New issue
Advanced search Search tips

Issue 895448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

adding_third_party doc is gibberish (in parts at least)

Project Member Reported by siggi@chromium.org, Oct 15

Issue description

The doc currently references the SVN repo, which is outdated by a fair bit. 

I also cannot sensibly parse this section:
--- cut here ---
If the code is applicable and will be compiled on all supported Chromium
platforms (Windows, Mac, Linux, Chrome OS, iOS, Android), check it in to
[src/third_party](http://src.chromium.org/viewvc/chrome/trunk/src/third_party/).

If the code is only applicable to certain platforms, check it in to
[src/third_party](http://src.chromium.org/viewvc/chrome/trunk/src/third_party/)
and add an entry to the
[DEPS](http://src.chromium.org/viewvc/chrome/trunk/src/DEPS) file that causes
the code to be checked out from src/third_party into src/third_party by gclient.
-- cut here ---

if all, put in location X, otherwise put in locationX?
 
Owner: dpranke@google.com
Status: Assigned (was: Untriaged)
Dirk, you've been in that file recently, can you fix or reassign, please?
Owner: dpranke@chromium.org
Sure, I'll take this.
Status: Fixed (was: Assigned)
Should be fixed now, in https://chromium-review.googlesource.com/c/1298650 .

Sign in to add a comment