New issue
Advanced search Search tips

Issue 895431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The AEC3 echo suppressor is to conservative during saturated echo

Project Member Reported by peah@chromium.org, Oct 15

Issue description

When the echo is saturated, the AEC3 echo suppressor operates in a more conservative mode. Test results indicate that this mode is more conservative than needed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d

commit 3e7b7b154b6f40697c30bcc07c7dbc153389bd8d
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Oct 16 13:22:44 2018

AEC3: Changes to initial behavior and handling of saturated echo

This CL introduces two related changes
1) It changes the way that the AEC3 determines whether the linear
filter is sufficiently good for its output to be used. The new scheme
achieves this much earlier than what was done in the legacy scheme.
2) It changes the way that saturated echo is and handled so that the
impact of the nearend speech is lower.

Bug:  webrtc:9835 , webrtc:9843 , chromium:895435 , chromium:895431 
Change-Id: I0b493676886e2134205e9992bbe4badac7e414cc
Reviewed-on: https://webrtc-review.googlesource.com/c/104380
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25208}
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/aec_state_unittest.cc
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/subtractor_output.cc
[modify] https://crrev.com/3e7b7b154b6f40697c30bcc07c7dbc153389bd8d/modules/audio_processing/aec3/subtractor_output.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41a24342cf15e0139141d33c61346bea80d1c5d

commit f41a24342cf15e0139141d33c61346bea80d1c5d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 21:57:53 2018

Roll src/third_party/webrtc 1927dfafabc0..9b1d67982f26 (23 commits)

https://webrtc.googlesource.com/src.git/+log/1927dfafabc0..9b1d67982f26


git log 1927dfafabc0..9b1d67982f26 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 mbonadei@webrtc.org Remove 'iOS32 Sim Debug (iOS 9.0)' from client.webrtc.
2018-10-16 niklas.enbom@webrtc.org Revert "Remove the HighPassFilter interface"
2018-10-16 peah@webrtc.org Avoids creating empty call_order file when no call order data is written
2018-10-16 danilchap@webrtc.org Calculate max payload size for an rtp packet to fit full video frame
2018-10-16 srte@webrtc.org Don't send max allocation probe unless allocation changed.
2018-10-16 terelius@webrtc.org Update proto for new event log format.
2018-10-16 nisse@webrtc.org Delete wrappers for snprintf and vsnprintf
2018-10-16 magjed@webrtc.org Use color aligning in video quality analysis tool
2018-10-16 peah@webrtc.org AEC3: Changes to initial behavior and handling of saturated echo
2018-10-16 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 3).
2018-10-16 srte@webrtc.org Using more specific dependencies in rtc_base.
2018-10-16 danilchap@webrtc.org Always verify packet wasn't resend recently before resending it.
2018-10-16 brandtr@webrtc.org Remove |hw_encoder| and |hw_decoder| from VideoCodecTestFixture::Config.
2018-10-16 nisse@webrtc.org Delete unused code in rtc_base/stringutils.*
2018-10-16 artit@webrtc.org Add generate_ios_coverage_command.py script
2018-10-16 srte@webrtc.org Removing unnecessary dependencies on socket.h.
2018-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0cecb6ce10..f8cad916e6 (599821:599923)
2018-10-16 saza@webrtc.org Remove AECM comfort noise setting from API
2018-10-16 saza@webrtc.org Remove the HighPassFilter interface
2018-10-16 peterhanspers@webrtc.org Adding support for logging severity LS_NONE.
2018-10-16 nisse@webrtc.org Implement test class LoopbackMediaTransport
2018-10-16 asapersson@webrtc.org Add test that verifies that VideoEncoderConfig max_framerate is reported to source.
2018-10-16 srte@webrtc.org Removes Clock instance from RoundRobinPacketQueue.


Created with:
  gclient setdep -r src/third_party/webrtc@9b1d67982f26

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:894434, chromium:895435 , chromium:895431 ,chromium:None,chromium:844647,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic49f27d148d1b629d7599b62fd91ba2a28e30935
Reviewed-on: https://chromium-review.googlesource.com/c/1284010
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600142}
[modify] https://crrev.com/f41a24342cf15e0139141d33c61346bea80d1c5d/DEPS

Status: Fixed (was: Started)

Sign in to add a comment