See the link to graphs below.
All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=895384 (For debugging:) Original alerts at time of bug-filing: https://chromeperf.appspot.com/group_report?sid=bcf04decffbc87a3f2b01be7b8dc94c678922dd4768c38422d041cff5e813cf3 Bot(s) for this bug's original alert(s): Android Nexus5 Perf mac-10_12_laptop_low_end-perf memory.desktop - Benchmark documentation link: None rendering.mobile - Benchmark documentation link: https://bit.ly/rendering-benchmarks
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/10695666e40000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/10695666e40000 Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets. by penghuang@chromium.org https://chromium.googlesource.com/chromium/src/+/0cb762482ab99e54be75368d8da949d52af00059 memory:chrome:all_processes:reported_by_chrome:skia:effective_size: 2.606e+07 → 2.695e+08 (+2.434e+08) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
Hi Robert & Greg, Could you please take a look? Thanks.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75 commit e1fc3396bdc0b6a7091e3ad318a0085cd0989a75 Author: Peng Huang <penghuang@chromium.org> Date: Mon Oct 15 20:50:31 2018 Revert "Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets." This reverts commit 0cb762482ab99e54be75368d8da949d52af00059. Reason for revert: performance regressions Original change's description: > Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets. > > Enable those two options which may improve skia performance. > > Bug: 894492 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d > Reviewed-on: https://chromium-review.googlesource.com/c/1273267 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#599321} TBR=penghuang@chromium.org,robertphillips@google.com,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894492 ,895408, 895384 , 895377 , 895369 , 895280 Change-Id: I657077091716a618d18a3d1109531e6b3819108c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1281055 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599741} [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/components/viz/service/gl/gpu_service_impl.cc [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/components/viz/test/data/rotated_drop_shadow_filter_gl.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/components/viz/test/data/rotated_filter_gl.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/gpu/skia_bindings/grcontext_for_gles2_interface.cc [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/compositing/masks/mask-with-added-filters-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.png [delete] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-layer-crash-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/compositing/masks/mask-with-added-filters-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png [delete] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/WebKit/LayoutTests/platform/win/images/color-profile-layer-filter-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png [modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-layer-crash-expected.png [add] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/virtual/video-surface-layer/media/video-layer-crash-expected.png
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 15