Issue metadata
Sign in to add a comment
|
3.4%-4.3% regression in system_health.memory_desktop at 598437:598635 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 15
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14de34c6e40000
,
Oct 15
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14de34c6e40000 Make non-root layout views have isolation nodes. by vmpstr@chromium.org https://chromium.googlesource.com/chromium/src/+/a971ede805e09dbf5632a1c5366b92512fe8254a memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 7.285e+07 → 7.557e+07 (+2.715e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeb3499ace08617926f1d0a7ece1c5f1ed677001 commit eeb3499ace08617926f1d0a7ece1c5f1ed677001 Author: Vladimir Levin <vmpstr@chromium.org> Date: Tue Oct 16 17:49:24 2018 Disable iframe isolation nodes via a flag. This patch introduces a flag for layout view isolation nodes, since it seems to have caused a memory regression. The flag would allow to easily test the memory usage and other perf benefits. I'll remove the flag and enable by default when the problems are resolved. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Bug: 895270 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa74c997dc3d211d0a870fdff303a9c94b5312e9 Reviewed-on: https://chromium-review.googlesource.com/c/1282204 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600036} [modify] https://crrev.com/eeb3499ace08617926f1d0a7ece1c5f1ed677001/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc [modify] https://crrev.com/eeb3499ace08617926f1d0a7ece1c5f1ed677001/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc [modify] https://crrev.com/eeb3499ace08617926f1d0a7ece1c5f1ed677001/third_party/blink/renderer/platform/runtime_enabled_features.json5 |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 15