Non-Regression: Transparent screen appears for Set Wallpaper preview in overview mode |
||||
Issue descriptionChrome Version:72.0.3580.0/11160.0.0 dev channel Kip, Daisy & Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >> Open 'Set Wallpaper Screen' in max size (2)Select any wallpaper for preview (3)Press overview mode and observe Actual:Transparent screen appears when Set Wallpaper preview is in overview mode Expected: Preview screen should be in overview mode instead of transparent screen This is a Non-Regression issue seen from M-70 Attached the screencast for reference..
,
Oct 17
We probably should not allow entering overview mode if we're currently in wallpaper preview mode.
,
Oct 17
The wallpaper picker exits preview mode by itself if its window resizes to non-full screen. But in overview mode, the wallpaper picker still thinks it's in full screen (There is no resize event https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js?type=cs&q=placeWallpaperPicker_&l=521 when you toggle to overview mode.) If this is expected, then we can add OnWallpaperPreviewStarted() observer in window_selector_controller.cc.
,
Oct 19
Re#3： Either do not allow entering overview if we're in preview mode or exiting preview mode when overview starts (Shouldn't we just add OnOverviewStarting() to WallpaperController?) makes sense for me. We may need a PM or UX's opinion here:)
,
Oct 19
Would it be possible to fill the preview window with the unblurred, scaled down wallpaper as if it was just a normal overview preview? I think the next least bad thing would be to exit out of the preview when overview is pressed. We shouldn't block overview opening.
,
Oct 19
Taking over since the changes in #5 are related to wallpaper. |
||||
►
Sign in to add a comment |
||||
Comment 1 by afakhry@chromium.org
, Oct 17Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)