+cc elly, I did this intentionally since extensions can have a "100" unread messages notifications. This will be clipped by the circular ink-drop. Thinking about it again I think it's fine though and the uglier focus ring is probably worse than obscuring the a few extensions with the focus ring.

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/toolbar/toolbar_action_view.cc?type=cs&q=toolbar_action_view.cc&sq=package:chromium&g=0&l=92

I think we can just remove the FocusRing::SetPath call here, unless you think obscuring a few extension icons when focused is a problem. I'll put up a CL, let me know if you disagree.

#1: Agree.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019423bf4be51d4547a2309741eb666a39a7b718

commit 019423bf4be51d4547a2309741eb666a39a7b718
Author: Peter Boström <pbos@chromium.org>
Date: Mon Oct 15 22:55:02 2018

Fix touchable insets for Avatar/Cast toolbar icons

An earlier refactoring set zero-insets for touchable AvatarToolbarButton
instead of insets for TOOLBAR_BUTTON. This API was confusing to use so
SetLayoutInsets was changed and renamed to SetLayoutInsetDelta to make
it easier to use. Callers no longer need to include the call to
GetLayoutInsets(TOOLBAR_BUTTON).

CastToolbarButton having incorrect ink-drops was not a regression but
has always used a 16dp icon in both touchable and non-touchable modes.
This change also calls SetInsetDelta to make up for the missing 8dp.

Bug:  chromium:895263 
Change-Id: I30595913dfb8a19358d198d9f4e0dbcb37993117
Reviewed-on: https://chromium-review.googlesource.com/c/1281903
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599765}
[modify] https://crrev.com/019423bf4be51d4547a2309741eb666a39a7b718/chrome/browser/ui/views/media_router/cast_toolbar_button.cc
[modify] https://crrev.com/019423bf4be51d4547a2309741eb666a39a7b718/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
[modify] https://crrev.com/019423bf4be51d4547a2309741eb666a39a7b718/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/019423bf4be51d4547a2309741eb666a39a7b718/chrome/browser/ui/views/toolbar/toolbar_button.h

Wrong bug, #3 should've been  issue 895519 . CL up for review though.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c50b9cde47adf41c7ff5bfaa35239f77f563d26

commit 2c50b9cde47adf41c7ff5bfaa35239f77f563d26
Author: Peter Boström <pbos@chromium.org>
Date: Tue Oct 16 18:24:16 2018

Use circular focus rings for ToolbarActionView

Before this change, a square focus ring was recently added to make sure
that text set using chrome.browserAction.setBadgeText was not clipped by
the focus ring.

This new focus-ring style unfortunately looks very out of place, so this
change just removes the FocusRing::SetPath call so that it matches the
ink-drop style (and focus-ring style) of all toolbar buttons.

Obscuring the badge text is not too bad here since the text is clearly
visible when the view is not in focus and only partially occluded with
the focus ring present.

Bug:  chromium:895263 
Change-Id: I210893c84c138944f12923a1b844c833134ff7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1281904
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600050}
[modify] https://crrev.com/2c50b9cde47adf41c7ff5bfaa35239f77f563d26/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Requesting merge to M71 for #5 (#3 belongs to a different bug).

Update :
Rechecked the above issue on Mac OS X(10.13.1,10.13.6,10.14.1) using latest Canary build : 72.0.3583.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen-cast.

Thank you..!!

Deleted: Fixed_Behaviour.mov 4.0 MB

	Fixed_Behaviour.mov 4.0 MB View Download

Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Pls merge your change to M71 branch 3578 ASAP so we can pick it up for next M71 Dev/Beta release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1822e29096442cf7439a8a4223f1f7005832c324

commit 1822e29096442cf7439a8a4223f1f7005832c324
Author: Peter Boström <pbos@chromium.org>
Date: Wed Oct 17 21:14:01 2018

Use circular focus rings for ToolbarActionView

Before this change, a square focus ring was recently added to make sure
that text set using chrome.browserAction.setBadgeText was not clipped by
the focus ring.

This new focus-ring style unfortunately looks very out of place, so this
change just removes the FocusRing::SetPath call so that it matches the
ink-drop style (and focus-ring style) of all toolbar buttons.

Obscuring the badge text is not too bad here since the text is clearly
visible when the view is not in focus and only partially occluded with
the focus ring present.

Bug:  chromium:895263 
Change-Id: I210893c84c138944f12923a1b844c833134ff7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1281904
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600050}(cherry picked from commit 2c50b9cde47adf41c7ff5bfaa35239f77f563d26)
Reviewed-on: https://chromium-review.googlesource.com/c/1287195
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#99}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/1822e29096442cf7439a8a4223f1f7005832c324/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Update :
Rechecked the above issue on Mac OS X(10.13.1,10.13.6,10.14.1) using latest Dev build : 71.0.3578.20 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen-cast.

Thank you..!!

Deleted: Fixed_Behaviour.mov 3.2 MB

	Fixed_Behaviour.mov 3.2 MB View Download

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/1822e29096442cf7439a8a4223f1f7005832c324

Commit: 1822e29096442cf7439a8a4223f1f7005832c324
Author: pbos@chromium.org
Commiter: pbos@chromium.org
Date: 2018-10-17 21:14:01 +0000 UTC

Use circular focus rings for ToolbarActionView

Before this change, a square focus ring was recently added to make sure
that text set using chrome.browserAction.setBadgeText was not clipped by
the focus ring.

This new focus-ring style unfortunately looks very out of place, so this
change just removes the FocusRing::SetPath call so that it matches the
ink-drop style (and focus-ring style) of all toolbar buttons.

Obscuring the badge text is not too bad here since the text is clearly
visible when the view is not in focus and only partially occluded with
the focus ring present.

Bug:  chromium:895263 
Change-Id: I210893c84c138944f12923a1b844c833134ff7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1281904
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600050}(cherry picked from commit 2c50b9cde47adf41c7ff5bfaa35239f77f563d26)
Reviewed-on: https://chromium-review.googlesource.com/c/1287195
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#99}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}