Issue metadata
Sign in to add a comment
|
Regression: Search box is being active when opening the launcher when On screen keyboard is enabled |
||||||||||||||||||||||
Issue descriptionChrome Version:72.0.3580.0/11160.0.0 dev channel Kip, Daisy & Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user,from ubertray/Accessibility enable Onscreen Keyboard (2)Open app launcher and observe Actual: Search box is being active when opening the launcher Expected:search box should not be active when showing the launcher This is a Regression issue as same is working fine in 70.0.3538.34-beta Attached the screencast for reference..
,
Oct 15
,
Oct 15
Probs a dupe.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65827fc5fd5431bba046c01fd7102d563bb65d71 commit 65827fc5fd5431bba046c01fd7102d563bb65d71 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Oct 17 22:33:22 2018 Fix on-screen keyboard issue when search box is focused Background: In some devices like nocturne, on-screen keyboard pops up when launcher is focused. When launcher is focused, search box textfield will be the initial focused view. SearchBoxViewBase::ContentsChanged() gets called to activate the search box, which triggers the on-screen keyboard. Change: Avoid activate the search box when new contents are empty string. Bug: 895249 Change-Id: I32b0f5a76037b5287d1b179fa20140101ce4f853 Reviewed-on: https://chromium-review.googlesource.com/c/1284754 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600577} [modify] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/ui/chromeos/search_box/search_box_view_base.cc
,
Oct 17
,
Oct 18
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bae74eaef4613ceb3880e4b8a5a5a0f8b4eadb1 commit 9bae74eaef4613ceb3880e4b8a5a5a0f8b4eadb1 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Oct 18 23:44:12 2018 Fix on-screen keyboard issue when search box is focused Background: In some devices like nocturne, on-screen keyboard pops up when launcher is focused. When launcher is focused, search box textfield will be the initial focused view. SearchBoxViewBase::ContentsChanged() gets called to activate the search box, which triggers the on-screen keyboard. Change: Avoid activate the search box when new contents are empty string. Bug: 895249 Change-Id: I32b0f5a76037b5287d1b179fa20140101ce4f853 Reviewed-on: https://chromium-review.googlesource.com/c/1284754 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600577}(cherry picked from commit 65827fc5fd5431bba046c01fd7102d563bb65d71) Reviewed-on: https://chromium-review.googlesource.com/c/1290189 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#138} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9bae74eaef4613ceb3880e4b8a5a5a0f8b4eadb1/ui/chromeos/search_box/search_box_view_base.cc
,
Oct 18
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bae74eaef4613ceb3880e4b8a5a5a0f8b4eadb1 Commit: 9bae74eaef4613ceb3880e4b8a5a5a0f8b4eadb1 Author: weidongg@chromium.org Commiter: weidongg@chromium.org Date: 2018-10-18 23:44:12 +0000 UTC Fix on-screen keyboard issue when search box is focused Background: In some devices like nocturne, on-screen keyboard pops up when launcher is focused. When launcher is focused, search box textfield will be the initial focused view. SearchBoxViewBase::ContentsChanged() gets called to activate the search box, which triggers the on-screen keyboard. Change: Avoid activate the search box when new contents are empty string. Bug: 895249 Change-Id: I32b0f5a76037b5287d1b179fa20140101ce4f853 Reviewed-on: https://chromium-review.googlesource.com/c/1284754 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600577}(cherry picked from commit 65827fc5fd5431bba046c01fd7102d563bb65d71) Reviewed-on: https://chromium-review.googlesource.com/c/1290189 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#138} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Oct 15