Issue metadata
Sign in to add a comment
|
Regression : Glimpse of focus is seen in 'Person name' text box when navigating to 'Edit person' page from 'People' MacMenu.
Reported by
avsha...@etouch.net,
Oct 15
|
||||||||||||||||||||||
Issue descriptionChrome Version : 72.0.3580.0 (Official Build) 22f2abf9039333b9f97008e3f887b85f541d6cb9-refs/branch-heads/3580@{#1} 64 bit OS : Mac(10.13.1, 10.14.1, 10.13.6) What steps will reproduce the problem? 1. Launch chrome and open NTP. 2. Open 'People' Mac menu and select 'Edit..' option. 3. Immediately observe the 'Person name' text box. Actual Result : Glimpse of focus is seen in 'Person name' text box when navigating to 'Edit person' page from 'People' MacMenu. Expected Result : Glimpse of focus should not be seen in 'Person name' text box when navigating from 'People' MacMenu. This is a regression issue broken in M-71 and below is the 'Chromium bisect' information: Good Build : 71.0.3544.0 (Revision : 589077) Bad Build : 71.0.3545.0 (Revision : 589377) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/be9e708ab189d52a1a673ff1819100dfe959cd54..edfaf96ded09c8403ed924f62eee35489d47201d Suspecting : r589227 Esmael@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is not reproducible in Linux(14.04 LTS) and Windows(7,8,10) OS. 2. Unable to do 'per-revision' bisect as it shows "We don't have enough builds to bisect.." error message. 3. Tried on different machines but it still shows same error, hence providing suspect through 'Chromium bisect'. 4. Able to reproduce issue in Dev #71.0.3573.0 Thank you..!
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a4d9c87dd8b9a4446ffd34d3932101f85a40d76 commit 7a4d9c87dd8b9a4446ffd34d3932101f85a40d76 Author: Esmael El-Moslimany <aee@chromium.org> Date: Tue Oct 16 15:10:34 2018 Settings WebUI: settings-manage-profile, remove setting the input manually The profile name already has a data binding. When the /manageProfile page loads first, the profile name has not yet been retrieved when setting the input resulting in setting the input value to undefined which leads to a momentary invalid input. Once the profile name is set, the data binding to the input value will do the necessary update. Bug: 895205 Change-Id: Ibf3ef6c81e0e7fa73b52944ee4cdf8c72f1748d6 Reviewed-on: https://chromium-review.googlesource.com/c/1281222 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#599984} [modify] https://crrev.com/7a4d9c87dd8b9a4446ffd34d3932101f85a40d76/chrome/browser/resources/settings/people_page/manage_profile.js
,
Oct 16
,
Oct 17
--------- Update : --------- Verified above issue in latest Canary build #72.0.3583.0 on Mac(10.13.1, 10.13.6, 10.14.1) OS and the issue is fixed. No glimpse is seen in 'Person name' field when navigating to 'Edit person' page from 'People' MacMenu, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aee@chromium.org
, Oct 15