New issue
Advanced search Search tips

Issue 895183 link

Starred by 2 users
Status: Fixed
Owner:
aleventhal@chromium.org
Closed: Oct 15
Cc:
aboxhall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

[regression] Accessible tree not updating after element changed to display:inline and it has block siblings

Project Member Reported by aleventhal@chromium.org, Oct 15 
Steps:
1. Load attached example with NVDA, JAWS or VoiceOver.
2. Try to tab to checkbox

Checkbox shows up visually, but is not available to the virtual buffer.
display-to-inline.html
257 bytes View Download

Comment 1 by aleventhal@chromium.org, Oct 15

Summary: IA2 tree not updating after element changed to display:inline (was: IA2 tree not updating after collapsed combobox selection that dynamically adds more content)

Comment 2 by aleventhal@chromium.org, Oct 15

Description: Show this description

Comment 3 by aleventhal@chromium.org, Oct 15

Description: Show this description

Comment 4 by aleventhal@chromium.org, Oct 15

Description: Show this description

Comment 5 by aleventhal@chromium.org, Oct 15

Description: Show this description

Comment 6 by aleventhal@chromium.org, Oct 15

Summary: Accessible tree not updating after element changed to display:inline and it has block siblings (was: IA2 tree not updating after element changed to display:inline)

Comment 7 by aleventhal@chromium.org, Oct 15

Cc: aboxhall@chromium.org
Summary: [regression] Accessible tree not updating after element changed to display:inline and it has block siblings (was: Accessible tree not updating after element changed to display:inline and it has block siblings)
Here is the result of git bisect:
https://chromium-review.googlesource.com/c/chromium/src/+/1239296
"Process accessibility tree updates after layout is complete."
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc6c2f207279f4ee1f209aa154bd3299a5c921d

commit dcc6c2f207279f4ee1f209aa154bd3299a5c921d
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Oct 15 18:46:34 2018

Changing CSS display must update ax tree

The accessible tree was not being updated when layout tree included
nodeless objects, which are used to parent inline objects
when they have block siblings. This fixes the closest node logic used
to find a node for a layout object or layout ancestor.

Bug:  895183 
Change-Id: Iec46a5d97f60137a35350a9c4a5c89d45056a9a0
Reviewed-on: https://chromium-review.googlesource.com/c/1280789
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599697}
[modify] https://crrev.com/dcc6c2f207279f4ee1f209aa154bd3299a5c921d/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/dcc6c2f207279f4ee1f209aa154bd3299a5c921d/content/test/data/accessibility/css/display-to-block-expected-blink.txt
[add] https://crrev.com/dcc6c2f207279f4ee1f209aa154bd3299a5c921d/content/test/data/accessibility/css/display-to-block.html
[add] https://crrev.com/dcc6c2f207279f4ee1f209aa154bd3299a5c921d/content/test/data/accessibility/css/display-to-inline-expected-blink.txt
[add] https://crrev.com/dcc6c2f207279f4ee1f209aa154bd3299a5c921d/content/test/data/accessibility/css/display-to-inline.html
[modify] https://crrev.com/dcc6c2f207279f4ee1f209aa154bd3299a5c921d/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

Comment 9 by aleventhal@chromium.org, Oct 15

Status: Fixed (was: Started)
►

Sign in to add a comment