Issue metadata
Sign in to add a comment
|
measurements.smoothness_unittest.SmoothnessUnitTest.testSmoothness in telemetry_perf_unittests failing on multiple builders |
||||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of patricialor@google.com measurements.smoothness_unittest.SmoothnessUnitTest.testSmoothness in telemetry_perf_unittests failing on multiple builders Builders failed on: - Mac10.10 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests - Mac10.12 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests
,
Oct 15
+1 catapult-roll causes this failure. Looking at https://chromium.googlesource.com/catapult.git/+/0480f8caeb27101608c99e4df2f686d6697551f4%5E%21/ 'frame_times' was removed from stats: diff --git a/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py b/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py index aa1cd76..49ee9fb 100644 --- a/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py +++ b/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py @@ -11,10 +11,10 @@ class _MockRenderingStats(object): - stats = ['refresh_period', 'frame_timestamps', 'frame_times', 'paint_times', - 'painted_pixel_counts', 'record_times', 'recorded_pixel_counts', - 'input_event_latency', 'frame_queueing_durations', - 'main_thread_scroll_latency', 'gesture_scroll_update_latency'] + stats = ['paint_times', 'painted_pixel_counts', 'record_times', + 'recorded_pixel_counts', 'input_event_latency', + 'frame_queueing_durations', 'main_thread_scroll_latency', + 'gesture_scroll_update_latency'] However, tools/perf/measurements/smoothness_unittest.py is still using 'frame_times': def testSmoothness(self): ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html') measurement = smoothness.Smoothness() results = self.RunMeasurement(measurement, ps, options=self._options) self.assertFalse(results.had_failures) stat = rendering_util.ExtractStat(results) self.assertGreater(stat['frame_times'].mean, 0)
,
Oct 15
Disabled the test on mac: https://chromium-review.googlesource.com/c/chromium/src/+/1280242
,
Oct 16
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by patricia...@chromium.org
, Oct 15