New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895176 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 884020



Sign in to add a comment

We need icons for the "Computers" section of Drive.

Project Member Reported by slangley@chromium.org, Oct 15

Issue description

With the new "Computers" section we need icons for the top level and then the nested computers.

There is also the "USE and External Devices" section, should we re-use the USB icons here?

See screen shot.
 
Screenshot 2018-10-15 at 11.13.32 AM.png
127 KB View Download
For reference attaching what the web app looks like.
Screenshot 2018-10-18 at 2.38.08 PM.png
48.3 KB View Download
Labels: -Pri-3 M-72 OS-Chrome Pri-1
Friendly ping.
Cc: slangley@chromium.org mcirimele@chromium.org
Owner: gogoy@google.com
assigning this one to Gogo as a "get familiar with Chromium" first bug. 

Hi Gogo, can you help with this one? We do not need the GM2 icon since none of our other icons are GM2 yet. 
Blocking: 884020
Status: Started (was: Assigned)
Hi Gogo,

We cannot differentiate between different operating systems, so we only need 1 icon for "Computers". Which one would you like me to use?

Thanks
Let's use this generic one then: 
https://icons.googleplex.com/#icon=ic_laptop&search=laptop

Thanks
Hi Gogo,

I grabbed the icons, but i don't think they are quite right. I had to resize them all to 16x16 and 32x32, but the blue one does not match the blue that we use.

Please see attached screenshot, hopefully you can see the difference.

Can you please make the right icons?

Thanks,
Stuart






Screenshot 2018-11-16 at 10.22.52 AM.png
55.7 KB View Download
Hi Stuart, 

Sure I cam. What kind of file formats do you need? PNG/ SVG?

Thanks,
Gogo
We use PNG, need 1x and 2x sizes. (16x16 and 32x32)

Thanks!
Attached are the PNGs for the icon.  
Please let me know if there is an asset folder where I can upload the future icons. 
ic_computer_32.png
284 bytes View Download
ic_computer_16.png
203 bytes View Download
Cc: sgabr...@chromium.org
Hi Gogo,

I need the icons for:

- Computer inactive (what you've attached).
- Computer active (blue version of what you've attached).
- Devices inactive
- Devices active 

I've cc'd Sebastian who can probably do a better job of providing the right specs for icons than I can.

Thanks

All assets added to the current version of the Files app is done through the assets Sketch file located in:
System app - Files app (native) > Sources > files-app-assets.sketch
Link: https://drive.google.com/open?id=0B6x6iYCtKinEOHVuODRyU2VLcEk&authuser=sgabriel@google.com

Exported pngs should be put in their respective 100 and 200 folder here:
System app - Files app (native) > Assets > 100
System app - Files app (native) > Assets > 200
Link: https://drive.google.com/open?id=0B6x6iYCtKinEQmo5N1ByUHo2dmM&authuser=sgabriel@google.com

Once we  go to the new redesign model, feel free to organize the drive at you see fit :)
Thank you for the info Sebastien! 

Hi Stuart, 

I added the following into the asset folder(100 & 200 for 16x16,32x32 respectively) here: https://drive.google.com/corp/drive/u/1/folders/0B6x6iYCtKinEQmo5N1ByUHo2dmM

Computer_active(blue)
Computer_inactive
Devices_active(blue)
Devices_inactive

Let me know if there is any problems. 
Thanks


Gogo,

I don't see any icons added to the 200 folder, I only see the 4 new icons in the 100 folder. Can you double check?

Thanks


Gogo - any updates? I'd like to get these in before branch.
Looks like the 200 assets did not upload correctly. 
AS she's OOO this week I've re-exported the assets. See attached.

Also available on drive
100: https://drive.google.com/open?id=0B6x6iYCtKinEXzBLLW9QbTB4dDg&authuser=sgabriel@google.com
200: https://drive.google.com/open?id=0B6x6iYCtKinEeTRnMk9pVGhhTWc&authuser=sgabriel@google.com
assets.zip
3.5 KB Download
Status: Fixed (was: Started)
Thanks!

Sign in to add a comment