New issue
Advanced search Search tips

Issue 895080 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 23
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Drop all registrations on instanceID token change.

Project Member Reported by melandory@chromium.org, Oct 13

Issue description

When the instance Id token has changed all registrations should be dropped.
 
Labels: -Pri-3 Pri-1
Labels: Merge-Request-71
Pls apply applicable OSs label. Thank you.
Labels: OS-Linux OS-Mac OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 19

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M71 branch #3578 ASAP so we can pick it up for next M71 Beta release. Thank you.
Pls merge your change to M71 branch 3578 latest by 1:00 PM PT, Monday, 10/22 so we can pick it up for next week beta release. Thank you. 
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 22

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c73cd8ea502b2067d3620b33718dca4ce743299

commit 1c73cd8ea502b2067d3620b33718dca4ce743299
Author: Tanja Gornak <melandory@chromium.org>
Date: Mon Oct 22 13:00:07 2018

[Tango->FCM] Drop all registrations on instanceID token change.

TBR=melandory@chromium.org

(cherry picked from commit d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb)

Bug:  895080 
Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16
Reviewed-on: https://chromium-review.googlesource.com/c/1278762
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600794}
Reviewed-on: https://chromium-review.googlesource.com/c/1293458
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#204}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/1c73cd8ea502b2067d3620b33718dca4ce743299/components/invalidation/impl/per_user_topic_registration_manager.cc
[modify] https://crrev.com/1c73cd8ea502b2067d3620b33718dca4ce743299/components/invalidation/impl/per_user_topic_registration_manager.h
[modify] https://crrev.com/1c73cd8ea502b2067d3620b33718dca4ce743299/components/invalidation/impl/per_user_topic_registration_manager_unittest.cc

Status: Fixed (was: Untriaged)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/1c73cd8ea502b2067d3620b33718dca4ce743299

Commit: 1c73cd8ea502b2067d3620b33718dca4ce743299
Author: melandory@chromium.org
Commiter: melandory@chromium.org
Date: 2018-10-22 13:00:07 +0000 UTC

[Tango->FCM] Drop all registrations on instanceID token change.

TBR=melandory@chromium.org

(cherry picked from commit d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb)

Bug:  895080 
Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16
Reviewed-on: https://chromium-review.googlesource.com/c/1278762
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600794}
Reviewed-on: https://chromium-review.googlesource.com/c/1293458
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#204}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment