Drop all registrations on instanceID token change. |
|||||||
Issue descriptionWhen the instance Id token has changed all registrations should be dropped.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb commit d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb Author: Tanja Gornak <melandory@chromium.org> Date: Thu Oct 18 16:37:27 2018 [Tango->FCM] Drop all registrations on instanceID token change. Bug: 895080 Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16 Reviewed-on: https://chromium-review.googlesource.com/c/1278762 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#600794} [modify] https://crrev.com/d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb/components/invalidation/impl/per_user_topic_registration_manager.cc [modify] https://crrev.com/d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb/components/invalidation/impl/per_user_topic_registration_manager.h [modify] https://crrev.com/d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb/components/invalidation/impl/per_user_topic_registration_manager_unittest.cc
,
Oct 18
,
Oct 18
Pls apply applicable OSs label. Thank you.
,
Oct 19
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
Pls merge your change to M71 branch #3578 ASAP so we can pick it up for next M71 Beta release. Thank you.
,
Oct 21
Pls merge your change to M71 branch 3578 latest by 1:00 PM PT, Monday, 10/22 so we can pick it up for next week beta release. Thank you.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c73cd8ea502b2067d3620b33718dca4ce743299 commit 1c73cd8ea502b2067d3620b33718dca4ce743299 Author: Tanja Gornak <melandory@chromium.org> Date: Mon Oct 22 13:00:07 2018 [Tango->FCM] Drop all registrations on instanceID token change. TBR=melandory@chromium.org (cherry picked from commit d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb) Bug: 895080 Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16 Reviewed-on: https://chromium-review.googlesource.com/c/1278762 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600794} Reviewed-on: https://chromium-review.googlesource.com/c/1293458 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#204} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/1c73cd8ea502b2067d3620b33718dca4ce743299/components/invalidation/impl/per_user_topic_registration_manager.cc [modify] https://crrev.com/1c73cd8ea502b2067d3620b33718dca4ce743299/components/invalidation/impl/per_user_topic_registration_manager.h [modify] https://crrev.com/1c73cd8ea502b2067d3620b33718dca4ce743299/components/invalidation/impl/per_user_topic_registration_manager_unittest.cc
,
Oct 23
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c73cd8ea502b2067d3620b33718dca4ce743299 Commit: 1c73cd8ea502b2067d3620b33718dca4ce743299 Author: melandory@chromium.org Commiter: melandory@chromium.org Date: 2018-10-22 13:00:07 +0000 UTC [Tango->FCM] Drop all registrations on instanceID token change. TBR=melandory@chromium.org (cherry picked from commit d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb) Bug: 895080 Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16 Reviewed-on: https://chromium-review.googlesource.com/c/1278762 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600794} Reviewed-on: https://chromium-review.googlesource.com/c/1293458 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#204} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by melandory@chromium.org
, Oct 13