chell: firmware updater failure: Unrecognized option: -P |
||||||
Issue descriptionChrome Version: M71+ OS: Chrome What steps will reproduce the problem? (1) Install a M71+ chell image, AU or recovery What is the expected result? Success What happens instead? Using flashrom in current system rootfs with legacy target syntax. Starting Google_Chell firmware updater v5 (autoupdate)... >> Firmware updater started. ERROR: Unrecognized option: -P >> FAILED: Firmware updater stopped due to error. ERROR: Firmware update (autoupdate) failed. ERROR: Execution failed: ./updater5.sh (error code = 1)
,
Oct 13
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/ba3cefd7354e24cfb7ecb19cc0136857b0a7d02d commit ba3cefd7354e24cfb7ecb19cc0136857b0a7d02d Author: Hung-Te Lin <hungte@chromium.org> Date: Sat Oct 13 15:32:17 2018 updater5: Fix "Unrecognized option: -P" if PD image is available When PD image is available, we have to pass that to --pd_image. The updater5 had a typo there as ${IMAGE_pd} instead of ${IMAGE_PD} and caused execution failure. BUG= chromium:895060 TEST=Apply to chell firmware updater, and then invoke; executed without error. Change-Id: I54d066b53fd348e62866093750f942170da819fc Reviewed-on: https://chromium-review.googlesource.com/1278692 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/ba3cefd7354e24cfb7ecb19cc0136857b0a7d02d/pack_dist/updater5.sh
,
Oct 14
Assign to kbleicher@google.com - we need this merged in M71 so chell won't break in AU.
,
Oct 14
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/6f975c7f4e62a1459e57911ffef1cd2c1a15a5d2 commit 6f975c7f4e62a1459e57911ffef1cd2c1a15a5d2 Author: Hung-Te Lin <hungte@chromium.org> Date: Sun Oct 14 11:50:10 2018 updater5: Fix "Unrecognized option: -P" if PD image is available When PD image is available, we have to pass that to --pd_image. The updater5 had a typo there as ${IMAGE_pd} instead of ${IMAGE_PD} and caused execution failure. BUG= chromium:895060 TEST=Apply to chell firmware updater, and then invoke; executed without error. Change-Id: I54d066b53fd348e62866093750f942170da819fc Reviewed-on: https://chromium-review.googlesource.com/1278692 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit ba3cefd7354e24cfb7ecb19cc0136857b0a7d02d) Reviewed-on: https://chromium-review.googlesource.com/c/1278693 Trybot-Ready: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/6f975c7f4e62a1459e57911ffef1cd2c1a15a5d2/pack_dist/updater5.sh
,
Oct 14
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hungte@chromium.org
, Oct 13