New issue
Advanced search Search tips

Issue 895056 link

Starred by 2 users
Status: Fixed
Owner:
briannorris@chromium.org
Closed: Oct 25
Cc:
benchan@chromium.org
briannorris@chromium.org
evgreen@chromium.org
diand...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

net-misc/rmtfs: don't rely on /boot mountpoint

Project Member Reported by briannorris@chromium.org, Oct 13 
We rely on /boot existing in this line:

exec minijail0 --profile=minimalistic-mountns -inNlpvr --uts \
  -b /dev/qcom_rmtfs_mem1,,1 -b /sys -b /var/lib/rmtfs/boot,/boot,1 \
  -c 0x1000 \
  -- /usr/bin/rmtfs


But apparently, /boot only exists on test (and dev?) images, not on base images. Fortunately we're not using this in production yet, but we should fix that.

I'm actually not completely sure what to do for this -- I guess I'd need to create an entire new root (/) to use instead of relying on the minimalistic-mounts setup? Or maybe we just bite the bullet and change rmtfs's hardcoded /boot/ paths.

Comment 1 by briannorris@chromium.org, Oct 17

Cc: evgreen@chromium.org
Status: Started (was: Assigned)
I think I'm just going to patch rmtfs to avoid using /boot. It seems silly to set up a whole new tmpfs rootfs just to avoid this problem, when we have full control over the source. /boot is a silly place for these "filesystems" anyway, IMO.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/79e3b7e736c12c14b0a1e76776de363edf0b7912

commit 79e3b7e736c12c14b0a1e76776de363edf0b7912
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Oct 25 07:32:29 2018

net-misc/rmtfs: don't keep FS in /boot

The /boot directory exists on test images, but not necessarily on base
images, so minijail's /var/lib/rmtfs/boot -> /boot bind mount won't work
(it's trying to create a /boot directory on the "minimilastic-mountns"
rootfs, which is read-only). Since we have the source rmtfs and because
/boot is a silly place for what essentially is a virtual, stateful
partition, let's move it to /var/lib/rmtfs/boot instead.

BUG= chromium:895056 
TEST=`status rmtfs`, wifi on Cheza

Change-Id: I37492d960c6b02376aec883729a41f5013cabb1c
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1286357
Reviewed-by: Ben Chan <benchan@chromium.org>

[add] https://crrev.com/79e3b7e736c12c14b0a1e76776de363edf0b7912/net-misc/rmtfs/files/rmtfs-configure-boot-directory.patch
[modify] https://crrev.com/79e3b7e736c12c14b0a1e76776de363edf0b7912/net-misc/rmtfs/rmtfs-0.3_p20180711.ebuild
[modify] https://crrev.com/79e3b7e736c12c14b0a1e76776de363edf0b7912/net-misc/rmtfs/files/rmtfs.conf
[rename] https://crrev.com/79e3b7e736c12c14b0a1e76776de363edf0b7912/net-misc/rmtfs/rmtfs-0.3_p20180711-r6.ebuild

Comment 3 by briannorris@chromium.org, Oct 25

Status: Fixed (was: Started)
►

Sign in to add a comment