ExploreSites page: some icons appear rounded while others do not. |
|||||
Issue descriptionChrome Version: M71 branch 599034 OS: Android Some ESP icons (favicons) are rounded more than others. See attached screenshot. The issue is because the code does not scale icons to target size before rounding, so the rounding is applied first then scale - which causes all kinds of different round corners since they are scaled dependin gon initial size of the icon. The fix it is scale icon before rounding.
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/372bd912ae02545a4c6d2ad6519b389ff3fa9ce8 commit 372bd912ae02545a4c6d2ad6519b389ff3fa9ce8 Author: Dmitry Titov <dimich@chromium.org> Date: Sat Oct 13 02:07:55 2018 Fix scaling/rounding of icons on ExploreSitesPage. Bug: 895045 Change-Id: I2f542536bf61d8953d88f42959ee47f07e73150e Reviewed-on: https://chromium-review.googlesource.com/c/1279364 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#599466} [modify] https://crrev.com/372bd912ae02545a4c6d2ad6519b389ff3fa9ce8/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesTileView.java
,
Oct 15
,
Oct 16
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce2b4bfdec3b342652d91679cf2a26165232d03 commit 6ce2b4bfdec3b342652d91679cf2a26165232d03 Author: Dmitry Titov <dimich@chromium.org> Date: Wed Oct 17 00:15:28 2018 Fix scaling/rounding of icons on ExploreSitesPage. TBR=dimich@chromium.org (cherry picked from commit 372bd912ae02545a4c6d2ad6519b389ff3fa9ce8) Bug: 895045 Change-Id: I2f542536bf61d8953d88f42959ee47f07e73150e Reviewed-on: https://chromium-review.googlesource.com/c/1279364 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599466} Reviewed-on: https://chromium-review.googlesource.com/c/1285522 Reviewed-by: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#75} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/6ce2b4bfdec3b342652d91679cf2a26165232d03/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesTileView.java
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce2b4bfdec3b342652d91679cf2a26165232d03 Commit: 6ce2b4bfdec3b342652d91679cf2a26165232d03 Author: dimich@chromium.org Commiter: dimich@chromium.org Date: 2018-10-17 00:15:28 +0000 UTC Fix scaling/rounding of icons on ExploreSitesPage. TBR=dimich@chromium.org (cherry picked from commit 372bd912ae02545a4c6d2ad6519b389ff3fa9ce8) Bug: 895045 Change-Id: I2f542536bf61d8953d88f42959ee47f07e73150e Reviewed-on: https://chromium-review.googlesource.com/c/1279364 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599466} Reviewed-on: https://chromium-review.googlesource.com/c/1285522 Reviewed-by: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#75} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dim...@chromium.org
, Oct 13161 KB
161 KB View Download