"Choose your PIN" screen is shown after public session (e.g. demo session) logs in |
||||||||
Issue descriptionalemate@ could you take a look? Let me know if you don't have time. Please wait for https://chromium-review.googlesource.com/c/chromium/src/+/1272085 to land first, otherwise there's merge conflict. Thanks!
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed95e624b7279a87a1eff8d7b69e3cb559dfd533 commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533 Author: Wenzhao Zang <wzang@chromium.org> Date: Tue Oct 16 04:44:23 2018 cros: Hide Discover OOBE screen for public sessions Bug: 895031 Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 Reviewed-on: https://chromium-review.googlesource.com/c/1281165 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599853} [modify] https://crrev.com/ed95e624b7279a87a1eff8d7b69e3cb559dfd533/chrome/browser/chromeos/login/wizard_controller.cc
,
Oct 16
,
Oct 17
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06905a7db74e034c7ed19d0ba66d8497ed2905a5 commit 06905a7db74e034c7ed19d0ba66d8497ed2905a5 Author: Wenzhao Zang <wzang@chromium.org> Date: Wed Oct 17 16:48:42 2018 cros: Hide Discover OOBE screen for public sessions Bug: 895031 Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 Reviewed-on: https://chromium-review.googlesource.com/c/1281165 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533) Reviewed-on: https://chromium-review.googlesource.com/c/1286896 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#87} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/06905a7db74e034c7ed19d0ba66d8497ed2905a5/chrome/browser/chromeos/login/wizard_controller.cc
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4e28866b9ca662728adf282a189d0f2289aa65f commit a4e28866b9ca662728adf282a189d0f2289aa65f Author: Wenzhao (Colin) Zang <wzang@chromium.org> Date: Wed Oct 17 21:05:54 2018 Revert "cros: Hide Discover OOBE screen for public sessions" This reverts commit 06905a7db74e034c7ed19d0ba66d8497ed2905a5. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1250136 should be merged first. Original change's description: > cros: Hide Discover OOBE screen for public sessions > > Bug: 895031 > Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 > Reviewed-on: https://chromium-review.googlesource.com/c/1281165 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533) > Reviewed-on: https://chromium-review.googlesource.com/c/1286896 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#87} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=wzang@chromium.org Change-Id: Ib25c70a6f2b44f3620b863b0e08e9fb691944cd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895031 Reviewed-on: https://chromium-review.googlesource.com/c/1287194 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#98} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/a4e28866b9ca662728adf282a189d0f2289aa65f/chrome/browser/chromeos/login/wizard_controller.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06905a7db74e034c7ed19d0ba66d8497ed2905a5 Commit: 06905a7db74e034c7ed19d0ba66d8497ed2905a5 Author: wzang@chromium.org Commiter: wzang@chromium.org Date: 2018-10-17 16:48:42 +0000 UTC cros: Hide Discover OOBE screen for public sessions Bug: 895031 Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 Reviewed-on: https://chromium-review.googlesource.com/c/1281165 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533) Reviewed-on: https://chromium-review.googlesource.com/c/1286896 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#87} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4e28866b9ca662728adf282a189d0f2289aa65f Commit: a4e28866b9ca662728adf282a189d0f2289aa65f Author: wzang@chromium.org Commiter: wzang@chromium.org Date: 2018-10-17 21:05:54 +0000 UTC Revert "cros: Hide Discover OOBE screen for public sessions" This reverts commit 06905a7db74e034c7ed19d0ba66d8497ed2905a5. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1250136 should be merged first. Original change's description: > cros: Hide Discover OOBE screen for public sessions > > Bug: 895031 > Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 > Reviewed-on: https://chromium-review.googlesource.com/c/1281165 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533) > Reviewed-on: https://chromium-review.googlesource.com/c/1286896 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#87} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=wzang@chromium.org Change-Id: Ib25c70a6f2b44f3620b863b0e08e9fb691944cd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895031 Reviewed-on: https://chromium-review.googlesource.com/c/1287194 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#98} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 1
case: 17361688 I'm still seeing this issue on 71.0.3578.21 (Official Build) dev (64-bit) https://drive.google.com/open?id=1_VX5HG_bedh7m5Zfg9awuHUuf8NcV5w7 screenshot: https://drive.google.com/open?id=1yjR7L5SpzSeanN6yvSyqgbGIRtu-MCv8 policy: https://drive.google.com/open?id=1nh73JYjrfGgY_KQeEYY8r2fuYr_CFTxY policy json: https://drive.google.com/open?id=1E4S1EqqWk5A5xHqeGqt-4DVxbTDJ9_hP the commit of this bug landed in 71.0.3578.12 and 71.0.3578.13
,
Nov 1
,
Nov 2
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa8dd4a0e503e600b25163c20640d6fd5223bad commit 7fa8dd4a0e503e600b25163c20640d6fd5223bad Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Nov 02 17:52:39 2018 Reland "cros: Hide Discover OOBE screen for public sessions" This is a reland of 06905a7db74e034c7ed19d0ba66d8497ed2905a5 Original change's description: > cros: Hide Discover OOBE screen for public sessions > > Bug: 895031 > Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 > Reviewed-on: https://chromium-review.googlesource.com/c/1281165 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533) > Reviewed-on: https://chromium-review.googlesource.com/c/1286896 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#87} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} Bug: 895031 Change-Id: Ib4699e707fe66d6b98c0e414d030e68bf4067a10 Reviewed-on: https://chromium-review.googlesource.com/c/1315688 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#474} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/7fa8dd4a0e503e600b25163c20640d6fd5223bad/chrome/browser/chromeos/login/wizard_controller.cc
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa8dd4a0e503e600b25163c20640d6fd5223bad Commit: 7fa8dd4a0e503e600b25163c20640d6fd5223bad Author: wzang@chromium.org Commiter: wzang@chromium.org Date: 2018-11-02 17:52:39 +0000 UTC Reland "cros: Hide Discover OOBE screen for public sessions" This is a reland of 06905a7db74e034c7ed19d0ba66d8497ed2905a5 Original change's description: > cros: Hide Discover OOBE screen for public sessions > > Bug: 895031 > Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 > Reviewed-on: https://chromium-review.googlesource.com/c/1281165 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533) > Reviewed-on: https://chromium-review.googlesource.com/c/1286896 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#87} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} Bug: 895031 Change-Id: Ib4699e707fe66d6b98c0e414d030e68bf4067a10 Reviewed-on: https://chromium-review.googlesource.com/c/1315688 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#474} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 2
marcore@, thanks. Should be fixed after the reland in #13.
,
Nov 5
Tested on 71.0.3578.36. it's fixed, the "Choose your PIN" it's no more shown in enterprise public session |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by wzang@chromium.org
, Oct 15Owner: wzang@chromium.org
Status: Started (was: Assigned)