New issue
Advanced search Search tips

Issue 895026 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in fxcrt::UnownedPtr<unsigned char const>::ProbeForLowSeverityLifetimeIssue

Project Member Reported by ClusterFuzz, Oct 12

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5273645159809024

Fuzzer: libFuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x603000006b30
Crash State:
  fxcrt::UnownedPtr<unsigned char const>::ProbeForLowSeverityLifetimeIssue
  PDF_DataDecode
  CPDF_StreamAcc::ProcessFilteredData
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=599300:599311

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5273645159809024

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 12

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 12

Cc: dsinclair@chromium.org jam@chromium.org brucedaw...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Oct 12

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/0f567261d33a70860bb3ec3db4cf1185df1a9a54 (Make PDF_DataDecode()'s buffer out parameter a std::unique_ptr.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: -Security_Severity-High Security_Severity-Low
Cc: thestig@chromium.org
 Issue 895055  has been merged into this issue.
Project Member

Comment 6 by ClusterFuzz, Oct 13

Labels: OS-Windows
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/4f5ccaaecd7e524e98b79af6823a9ab6a8753d7f

commit 4f5ccaaecd7e524e98b79af6823a9ab6a8753d7f
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Oct 13 06:39:00 2018

Fix span / unique_ptr destruction order in PDF_DataDecode().

BUG= chromium:895026 

Change-Id: Ie7d8bfd6e42308c3531ce6637ad29ec2231a2095
Reviewed-on: https://pdfium-review.googlesource.com/c/43984
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/4f5ccaaecd7e524e98b79af6823a9ab6a8753d7f/core/fpdfapi/parser/fpdf_parser_decode.cpp

 Issue 895067  has been merged into this issue.
Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13071d410865e477c39fc706ff72a6de73c51dd5

commit 13071d410865e477c39fc706ff72a6de73c51dd5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Oct 13 09:19:22 2018

Roll src/third_party/pdfium 355f9eaaf10a..4f5ccaaecd7e (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/355f9eaaf10a..4f5ccaaecd7e


git log 355f9eaaf10a..4f5ccaaecd7e --date=short --no-merges --format='%ad %ae %s'
2018-10-13 thestig@chromium.org Fix span / unique_ptr destruction order in PDF_DataDecode().
2018-10-13 thestig@chromium.org Make testing/ pass gn check.
2018-10-13 thestig@chromium.org Fix v8 ToLocalChecked() failure in CJS_Runtime.


Created with:
  gclient setdep -r src/third_party/pdfium@4f5ccaaecd7e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:895026 , chromium:894938 
TBR=dsinclair@chromium.org

Change-Id: I385c86e2fdb8668f66ff1842698837b25f463ae2
Reviewed-on: https://chromium-review.googlesource.com/c/1279913
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599501}
[modify] https://crrev.com/13071d410865e477c39fc706ff72a6de73c51dd5/DEPS

Project Member

Comment 11 by sheriffbot@chromium.org, Oct 13

Labels: Pri-2
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 13

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by ClusterFuzz, Oct 14

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6720560317595648 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by ClusterFuzz, Oct 15

ClusterFuzz has detected this issue as fixed in range 599500:599501.

Detailed report: https://clusterfuzz.com/testcase?key=5273645159809024

Fuzzer: libFuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x603000006b30
Crash State:
  fxcrt::UnownedPtr<unsigned char const>::ProbeForLowSeverityLifetimeIssue
  PDF_DataDecode
  CPDF_StreamAcc::ProcessFilteredData
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=599300:599311
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=599500:599501

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5273645159809024

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by sheriffbot@chromium.org, Jan 19 (3 days ago)

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment