New issue
Advanced search Search tips

Issue 895022 link

Starred by 1 user
Status: Fixed
Owner:
rockot@google.com
Closed: Oct 22
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move Embedded{ServiceInfo/ServiceRunner/InstanceManager} to client lib

Project Member Reported by roc...@chromium.org, Oct 12 
These are helpers which any service can use to facilitate running multiple sub-services within its process. Today they're pretty much only used by content/browser and ios code, but more importantly they don't have a single dependency on other parts of services/service_manager/embedder and shouldn't be part of that target.

These should be moved to the client library. As an initial step we can at least separate the targets to stop child process code from linking against the SM implementation.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99973117f2a22bac22c7d8c725a2cee1f2a1543e

commit 99973117f2a22bac22c7d8c725a2cee1f2a1543e
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Oct 16 00:42:36 2018

[service-manager] Move EmbeddedServiceInfo etc

This pulls EmbeddedInstanceManager, EmbeddedServiceRunner, and
EmbeddedServiceInfo out of the //services/service_manager/embedder
target and into the client library, where they belong. These types
are used only by client code to facilitate embedding services within
other services and they require no linkage to the Service Manager
implementation.

Bug:  895022 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I180d9eff440c2b3a06e62b8784bdd2747822842d
Reviewed-on: https://chromium-review.googlesource.com/c/1279327
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599797}
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ash/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ash/DEPS
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ash/ash_service.cc
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/chrome/browser/chrome_service.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/browser/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/child/service_factory.cc
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/child/service_factory.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/common/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/common/service_manager/service_manager_connection_impl.cc
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/gpu/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/public/browser/browser_context.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/public/browser/content_browser_client.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/public/common/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/public/common/service_manager_connection.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/content/public/utility/content_utility_client.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/chrome/browser/unzip/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/chrome/browser/unzip/DEPS
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/chrome/browser/unzip/unzip_service_creator.cc
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/public/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/public/DEPS
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/public/browser_state.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/public/service_manager_connection.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/public/web_client.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/service_manager_connection_impl.cc
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/service_manager_context.mm
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/ios/web/webui/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/embedder/BUILD.gn
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/BUILD.gn
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_instance_manager.cc
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_instance_manager.h
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_instance_manager_unittest.cc
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_service_info.cc
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_service_info.h
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_service_runner.cc
[rename] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/public/cpp/embedded_service_runner.h
[modify] https://crrev.com/99973117f2a22bac22c7d8c725a2cee1f2a1543e/services/service_manager/tests/BUILD.gn

Comment 2 by roc...@chromium.org, Oct 17

Owner: rockot@google.com

Comment 3 by rockot@google.com, Oct 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment