New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 895020 link

Starred by 5 users
Status: Fixed
Owner:
zmo@chromium.org
Closed: Oct 22
Cc:
█ kbr@chromium.org
geoffl...@chromium.org
█ vikassoni@chromium.org
sadrul@chromium.org
ericrk@chromium.org
piman@chromium.org
jdarpinian@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 894440


Sign in to add a comment

Test failure on Nexus 9: GpuProcess_disabling_workarounds_works

Project Member Reported by jdarpinian@chromium.org, Oct 12 
http://crrev.com/c/1276549 for bug 894440 caused GpuProcess_disabling_workarounds_works to start failing on Nexus 9 because of a DCHECK.

Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%209%29/9176

piman@ suggests: "From reading the code, the test disables the workaround entry for this device (id 115) because it contains some uncommon test (on gl version).
Disabling workarounds yet running the full GPU stack is probably a bad idea. We should fix the test (i.e. the GpuControlList::Entry::AppliesToTestGroup logic).
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee62a03efac97e7b4a8c2ea641591e51632951df

commit ee62a03efac97e7b4a8c2ea641591e51632951df
Author: James Darpinian <jdarpinian@chromium.org>
Date: Sat Oct 13 00:44:27 2018

Disable test GpuProcess_disabling_workarounds_works on Nexus 9.

Started failing after http://crrev.com/c/1276549. The test should be fixed.

TBR: piman@chromium.org
Bug:  895020 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iff6a228194fe4404951d8592f0f26fe4b966bc8b
Reviewed-on: https://chromium-review.googlesource.com/c/1279347
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599446}
[modify] https://crrev.com/ee62a03efac97e7b4a8c2ea641591e51632951df/content/test/gpu/gpu_tests/gpu_process_expectations.py

Comment 2 by piman@chromium.org, Oct 13

Cc: sadrul@chromium.org
Owner: zmo@chromium.org
->zmo who implemented that logic with https://chromium-review.googlesource.com/862729 /  https://chromium-review.googlesource.com/865814

Comment 3 by zmo@chromium.org, Oct 13 

[FATAL:display.cc(532)] Check failed: false.

Searching Chromium source, I can't seem to find a display.cc file that has line #532.

Comment 4 by sadrul@chromium.org, Oct 13 

The crash is happening in https://cs.chromium.org/chromium/src/components/viz/service/display/display.cc?l=532 (which was added in https://chromium-review.googlesource.com/c/chromium/src/+/1276549). This means we are getting a presentation-timestamp that is coming from the future. I assume the blacklist/driver-bug list change makes this test use presentation-feedback, whereas it would normally be disabled on that device.

Comment 5 by zmo@chromium.org, Oct 13 

Thanks. It seems cs.chromium.org hasn't updated it's index yet.

Comment 6 by sadrul@chromium.org, Oct 16

Cc: geoffl...@chromium.org jdarpinian@chromium.org ericrk@chromium.org
 Issue 895852  has been merged into this issue.

Comment 7 by ericrk@google.com, Oct 16

Cc: kbr@chromium.org vikassoni@chromium.org
 Issue 895938  has been merged into this issue.

Comment 8 by zmo@google.com, Oct 18

Status: Started (was: Assigned)

Comment 9 by zmo@google.com, Oct 18 

 Issue 895945  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8241b8e3270f62b8018e273ac0e5fb0586c40324

commit 8241b8e3270f62b8018e273ac0e5fb0586c40324
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Oct 22 22:50:57 2018

Change gpu driver bug list test_group semantics from replace to append

Because we don't want to disable necessary workarounds on bots, otherwise
Chrome run may fail.

BUG= 895020 , 895945 
TEST=gpu_unittests,gpu_integration_test:gpu_process
R=piman@chromium.org

Change-Id: I496e3cac9f16943d57cb10334648c1b54f976543
Reviewed-on: https://chromium-review.googlesource.com/c/1289699
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601758}
[modify] https://crrev.com/8241b8e3270f62b8018e273ac0e5fb0586c40324/content/test/gpu/gpu_tests/gpu_process_expectations.py
[modify] https://crrev.com/8241b8e3270f62b8018e273ac0e5fb0586c40324/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/8241b8e3270f62b8018e273ac0e5fb0586c40324/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/8241b8e3270f62b8018e273ac0e5fb0586c40324/gpu/config/gpu_control_list_format.txt
[modify] https://crrev.com/8241b8e3270f62b8018e273ac0e5fb0586c40324/gpu/config/gpu_switches.cc

Comment 12 by zmo@chromium.org, Oct 22

Status: Fixed (was: Started)
►

Sign in to add a comment