Network error screen is messy when showing extra texts on top of the drop down list |
|||||||||||||
Issue descriptionNocturne - R71- 11150.0.0, 71.0.3575.1 zalcorn@, elizabethchiu@, per offline chat with alemate@, we have two options: 1) Reduce the height of the network drop down list, so that the bottom two lines of texts will move up. However, the drop down will be very narrow, and probably can only show one network entry at a time. 2) Make all the contents scrollable, which is easier to implement, but users have to scroll down to the bottom in order to see the "browser as guest" and "sign in as existing user" options. Any ideas?
,
Oct 12
alemate@ PTAL.
,
Oct 12
Current offset is 64px. Reducing it to 40 does not help much. So I moved network-list to the bottom.
,
Oct 12
https://screenshot.googleplex.com/ftMnXJgsh9m.png (arbitrary resized)
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e33d6c078151a3157ff8affdb6dddd1d493f4c81 commit e33d6c078151a3157ff8affdb6dddd1d493f4c81 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Oct 13 02:35:57 2018 Chrome OS: allow scrolling on the Error screen. Bug: 895000 Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59 Reviewed-on: https://chromium-review.googlesource.com/c/1279385 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599470} [modify] https://crrev.com/e33d6c078151a3157ff8affdb6dddd1d493f4c81/chrome/browser/resources/chromeos/login/screen_error_message.css [modify] https://crrev.com/e33d6c078151a3157ff8affdb6dddd1d493f4c81/chrome/browser/resources/chromeos/login/screen_error_message.html
,
Oct 13
,
Oct 14
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117 commit 3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Oct 15 19:54:46 2018 Chrome OS: allow scrolling on the Error screen. TBR=alemate@chromium.org (cherry picked from commit e33d6c078151a3157ff8affdb6dddd1d493f4c81) Bug: 895000 Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59 Reviewed-on: https://chromium-review.googlesource.com/c/1279385 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599470} Reviewed-on: https://chromium-review.googlesource.com/c/1281173 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#26} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117/chrome/browser/resources/chromeos/login/screen_error_message.css [modify] https://crrev.com/3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117/chrome/browser/resources/chromeos/login/screen_error_message.html
,
Oct 16
,
Oct 18
Issue 896460 has been merged into this issue.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117 Commit: 3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117 Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-10-15 19:54:46 +0000 UTC Chrome OS: allow scrolling on the Error screen. TBR=alemate@chromium.org (cherry picked from commit e33d6c078151a3157ff8affdb6dddd1d493f4c81) Bug: 895000 Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59 Reviewed-on: https://chromium-review.googlesource.com/c/1279385 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599470} Reviewed-on: https://chromium-review.googlesource.com/c/1281173 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#26} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
Per offline chat. Approving for M70 ChromeOS. The fix looks correct in M71.
,
Oct 23
,
Oct 23
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a58929de5bbad7dfcf649164a89fa81dad1af37 Commit: 9a58929de5bbad7dfcf649164a89fa81dad1af37 Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-10-23 23:17:51 +0000 UTC Chrome OS: allow scrolling on the Error screen. TBR=alemate@chromium.org (cherry picked from commit e33d6c078151a3157ff8affdb6dddd1d493f4c81) (cherry picked from commit 3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117) Bug: 895000 Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59 Reviewed-on: https://chromium-review.googlesource.com/c/1279385 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#599470} Reviewed-on: https://chromium-review.googlesource.com/c/1281173 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3578@{#26} Cr-Original-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} Reviewed-on: https://chromium-review.googlesource.com/c/1297600 Cr-Commit-Position: refs/branch-heads/3538@{#1041} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a58929de5bbad7dfcf649164a89fa81dad1af37 commit 9a58929de5bbad7dfcf649164a89fa81dad1af37 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Oct 23 23:17:51 2018 Chrome OS: allow scrolling on the Error screen. TBR=alemate@chromium.org (cherry picked from commit e33d6c078151a3157ff8affdb6dddd1d493f4c81) (cherry picked from commit 3e47f6bfdc60322ddff8cc0e4c7211dcf09d8117) Bug: 895000 Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59 Reviewed-on: https://chromium-review.googlesource.com/c/1279385 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#599470} Reviewed-on: https://chromium-review.googlesource.com/c/1281173 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3578@{#26} Cr-Original-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} Reviewed-on: https://chromium-review.googlesource.com/c/1297600 Cr-Commit-Position: refs/branch-heads/3538@{#1041} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/9a58929de5bbad7dfcf649164a89fa81dad1af37/chrome/browser/resources/chromeos/login/screen_error_message.css [modify] https://crrev.com/9a58929de5bbad7dfcf649164a89fa81dad1af37/chrome/browser/resources/chromeos/login/screen_error_message.html |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by zalcorn@chromium.org
, Oct 12