New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894995 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-config/mosys: cleanup: Normalize unibuild platform name match between x86 and arm

Project Member Reported by philipchen@chromium.org, Oct 12

Issue description

We're going to support sku-id as an unibuild identifier for ARM:

https://chromium-review.googlesource.com/c/chromiumos/platform/mosys/+/1274767

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1271458


As both x86 and ARM share sku-id identity, we should be able to better consolidate the ways we identify boards/models in unibuild.

Please find more details in Charles' comments here:

When these (x86 vs arm) were method level deltas, i guess it didn't matter as much, but now it stands out a bit more

for x86, we read smbios and then call this method
for arm, we call this method and let it read device compatible string 

it's inconsistent and causes a lot of the ifdefs

could we change it to:
x86 - read smbios
arm - read dt compatible string

normalize this to platform name match (we could also collapse the yaml also now since they share sku)

now we'd share all of the cros_config match code and just have the deltas on the identity read (which is the only part that's actually different)

 
Summary: chromeos-config/mosys: cleanup: Normalize unibuild platform name match between x86 and arm (was: chromeos-config/mosys: cleanup: Minimize the deltas on how we handle x86 and arm in unibuild)
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
Cc: shapiroc@chromium.org
Owner: nedngu...@google.com
Status: Available (was: Assigned)
Build team will take over this, reassigning to me to triage
Cc: -philipchen@chromium.org -nsanders@chromium.org philipc...@chromium.or
Owner: andrewlamb@chromium.org
This is already queue'd as starter bug.

Sign in to add a comment