Dragging files into left hand nav is difficult and buggy |
||||
Issue descriptionChrome Version: 71.0.3572.0 What steps will reproduce the problem? (1) Select a few files in touch mode (2) Long press to "pick up" files (3) Drag files over to left hand navigation somewhere under the Downloads folder (write access) What is the expected result? The folder the user is "hovering" over is shown as in focus. If they drop the files there they will be moved. If the user hovers for a long time they will enter the folder and can drag the files back into the right side of Files app to move them. What happens instead? The drag shadow trails behind, the folders are not consistently highlighted when in focus, everything feels slow and it's unclear where my files went when I dropped them. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Oct 14
,
Oct 18
,
Dec 18
Not working on this atm.
- the speed of the "drag shadow"
- ok for me on my eve.
- the drag shadow includes an icon that shows you whether you can drop or
not on the thing your finger is currently over
- but your finger obscures the icon and you can't see that icon
- focus or not, you can drop if the icon indicates you can
- the "slow" is when you hover on something
- it eventually gets focus and causes a navigation (to a directory)
- on some sort of time-out, which seems set to a very long value
- maybe to avoid "flashing" file-list redraws on fast navigations
All round, the goal would be to make dropping less difficult. It is not buggy, since drops work, but the UI interaction model needs reconsideration imho.
That time-out seems to be here
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js?q=FileTransferController&sq=package:chromium&dr=CSs&l=1260
this.navigateTimer_ =
setTimeout(this.changeToDropTargetDirectory_.bind(this), 2000);
IC, 2 seconds.
,
Dec 18
The 2 second delay was added during issue 137980 . Some discussion of it there. Patch was https://chromiumcodereview.appspot.com/12677002. More recently, Crostini was made special in that it does not wait 2 seconds ever https://chromium.googlesource.com/chromium/src/+/28744569f6d88d923529366ac2e18bbdda830680 If you drag over crostini, looks like file-list would immediately redraw. I wonder if file-list appears to flash if you move in/out of crostini? Anyhow, that it the other extreme, no timeout at all.
,
Dec 18
The 2 second delay was added during issue 137980 . Some discussion of it there. Patch was https://chromiumcodereview.appspot.com/12677002. More recently, Crostini was made special in that it does not wait 2 seconds ever https://chromium.googlesource.com/chromium/src/+/28744569f6d88d923529366ac2e18bbdda830680 If you drag over crostini, looks like file-list would immediately redraw. I wonder if file-list appears to flash if you move in/out of crostini? Anyhow, that it the other extreme, no timeout at all. |
||||
►
Sign in to add a comment |
||||
Comment 1 by mcirimele@chromium.org
, Oct 12