seems there are a lot of data in the file, i don't think there are so many interrupted downloads out there. And since we don't record download state, no idea whether these data can be deleted. We should clean it up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e518158159a42ad2e91add1a8d00b10b9d60579f commit e518158159a42ad2e91add1a8d00b10b9d60579f Author: Min Qin <qinmin@chromium.org> Date: Tue Oct 16 19:20:57 2018 No longer migrating data from MetadataCache MetadataCache is being deprecated. For M70, we started migrating all data to DownloadDBCache. For M71, we will stop using MetadataCache data at all. All migrated data will be destroyed afterwards as the data could be outdated. BUG= 894978 Change-Id: I2f7a070726cdd22d9188dc61f33816db4741ba5e Reviewed-on: https://chromium-review.googlesource.com/c/1279192 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600076} [modify] https://crrev.com/e518158159a42ad2e91add1a8d00b10b9d60579f/components/download/internal/common/download_db_cache.cc [modify] https://crrev.com/e518158159a42ad2e91add1a8d00b10b9d60579f/components/download/internal/common/download_db_cache.h [modify] https://crrev.com/e518158159a42ad2e91add1a8d00b10b9d60579f/components/download/internal/common/download_db_cache_unittest.cc [modify] https://crrev.com/e518158159a42ad2e91add1a8d00b10b9d60579f/components/download/internal/common/in_progress_download_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d commit 3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d Author: Min Qin <qinmin@chromium.org> Date: Fri Oct 19 00:43:57 2018 Remove InProgressCache InProgressCache is no longer being used as we are switching to in-progress db. Remove the class and its usage BUG= 894978 Change-Id: I1309de54c265e60f6e707765f67b7a1666b0e9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1289167 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600999} [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/chrome/browser/download/chrome_download_manager_delegate.cc [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/components/download/database/BUILD.gn [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/components/download/database/download_db_impl.cc [delete] https://crrev.com/cd1f5528e827705d9d158f67e947c2783f07a576/components/download/database/in_progress/in_progress_cache.h [delete] https://crrev.com/cd1f5528e827705d9d158f67e947c2783f07a576/components/download/database/in_progress/in_progress_cache_impl.cc [delete] https://crrev.com/cd1f5528e827705d9d158f67e947c2783f07a576/components/download/database/in_progress/in_progress_cache_impl.h [delete] https://crrev.com/cd1f5528e827705d9d158f67e947c2783f07a576/components/download/database/in_progress/in_progress_cache_impl_unittest.cc [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/components/download/internal/common/in_progress_download_manager.cc [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/components/download/public/common/in_progress_download_manager.h [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/content/browser/download/download_manager_impl.cc [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/content/browser/download/download_manager_impl_unittest.cc [modify] https://crrev.com/3baab9c0f545fadf239b1ff8bd602e5f0b43ce0d/content/browser/download/download_utils.cc
Comment 1 by bugdroid1@chromium.org
, Oct 16