Framebust omnibox toast persists across navigations. |
||
Issue descriptionChrome Version: 69.0.3497.100 (Official Build) (64-bit) OS: Linux What steps will reproduce the problem? (1) Visit http://cr.kungfoo.net/framebust/ (2) Wait 1 second until a framebust happens and a toast appears (3) Navigate to www.google.com What is the expected result? The icon goes away What happens instead? It stays put
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7c25ef96ce3edb0864c4ee5e9aa00bb92a53d5b commit e7c25ef96ce3edb0864c4ee5e9aa00bb92a53d5b Author: Charlie Harrison <csharrison@chromium.org> Date: Tue Oct 16 15:03:52 2018 Fix framebust omnibox toast Currently, the icon persists across navigations, which is wrong. Bug: 894955 Change-Id: I5e2028668a249c0baeb3976297c499df3e61b3b3 Reviewed-on: https://chromium-review.googlesource.com/c/1279208 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599982} [modify] https://crrev.com/e7c25ef96ce3edb0864c4ee5e9aa00bb92a53d5b/chrome/browser/ui/blocked_content/framebust_block_tab_helper.cc [modify] https://crrev.com/e7c25ef96ce3edb0864c4ee5e9aa00bb92a53d5b/chrome/browser/ui/blocked_content/framebust_block_tab_helper.h [modify] https://crrev.com/e7c25ef96ce3edb0864c4ee5e9aa00bb92a53d5b/chrome/browser/ui/blocked_content/popup_opener_tab_helper_unittest.cc [modify] https://crrev.com/e7c25ef96ce3edb0864c4ee5e9aa00bb92a53d5b/chrome/browser/ui/content_settings/framebust_block_browsertest.cc
,
Oct 18
|
||
►
Sign in to add a comment |
||
Comment 1 by csharrison@chromium.org
, Oct 12Status: Assigned (was: Untriaged)