New issue
Advanced search Search tips

Issue 894938 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Fatal error in v8::ToLocalCheckedv8::V8::ToLocalEmpty

Project Member Reported by ClusterFuzz, Oct 12

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5479190114336768

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: windows_libfuzzer_chrome_asan
Platform Id: windows

Crash Type: Fatal error
Crash Address: 
Crash State:
  v8::ToLocalCheckedv8::V8::ToLocalEmpty
  CJS_Runtime::GetValueByNameFromGlobalObject
  CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5479190114336768

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 12

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Owner: thestig@chromium.org
Is this related to the other Fuzzer + V8 issue?
Labels: OS-Chrome OS-Linux OS-Mac
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
https://pdfium-review.googlesource.com/43983
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/56e0c3ebe017135dcbd046bd6bc8c9ca54518597

commit 56e0c3ebe017135dcbd046bd6bc8c9ca54518597
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Oct 13 06:38:29 2018

Fix v8 ToLocalChecked() failure in CJS_Runtime.

BUG= chromium:894938 

Change-Id: I3d1ca33eec4cd2b01bfa4dfce7da3642dd5ad31b
Reviewed-on: https://pdfium-review.googlesource.com/c/43983
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/56e0c3ebe017135dcbd046bd6bc8c9ca54518597/fxjs/cjs_runtime.cpp

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13071d410865e477c39fc706ff72a6de73c51dd5

commit 13071d410865e477c39fc706ff72a6de73c51dd5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Oct 13 09:19:22 2018

Roll src/third_party/pdfium 355f9eaaf10a..4f5ccaaecd7e (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/355f9eaaf10a..4f5ccaaecd7e


git log 355f9eaaf10a..4f5ccaaecd7e --date=short --no-merges --format='%ad %ae %s'
2018-10-13 thestig@chromium.org Fix span / unique_ptr destruction order in PDF_DataDecode().
2018-10-13 thestig@chromium.org Make testing/ pass gn check.
2018-10-13 thestig@chromium.org Fix v8 ToLocalChecked() failure in CJS_Runtime.


Created with:
  gclient setdep -r src/third_party/pdfium@4f5ccaaecd7e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:895026 , chromium:894938 
TBR=dsinclair@chromium.org

Change-Id: I385c86e2fdb8668f66ff1842698837b25f463ae2
Reviewed-on: https://chromium-review.googlesource.com/c/1279913
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599501}
[modify] https://crrev.com/13071d410865e477c39fc706ff72a6de73c51dd5/DEPS

Project Member

Comment 8 by ClusterFuzz, Oct 14

ClusterFuzz has detected this issue as fixed in range 599500:599502.

Detailed report: https://clusterfuzz.com/testcase?key=5479190114336768

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: windows_libfuzzer_chrome_asan
Platform Id: windows

Crash Type: Fatal error
Crash Address: 
Crash State:
  v8::ToLocalCheckedv8::V8::ToLocalEmpty
  CJS_Runtime::GetValueByNameFromGlobalObject
  CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_libfuzzer_chrome_asan&range=599500:599502

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5479190114336768

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 14

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5479190114336768 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by ClusterFuzz, Oct 14

ClusterFuzz has detected this issue as fixed in range 599500:599502.

Detailed report: https://clusterfuzz.com/testcase?key=5479190114336768

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: windows_libfuzzer_chrome_asan
Platform Id: windows

Crash Type: Fatal error
Crash Address: 
Crash State:
  v8::ToLocalCheckedv8::V8::ToLocalEmpty
  CJS_Runtime::GetValueByNameFromGlobalObject
  CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_libfuzzer_chrome_asan&range=599500:599502

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5479190114336768

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Oct 14

ClusterFuzz has detected this issue as fixed in range 599500:599502.

Detailed report: https://clusterfuzz.com/testcase?key=5479190114336768

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: windows_libfuzzer_chrome_asan
Platform Id: windows

Crash Type: Fatal error
Crash Address: 
Crash State:
  v8::ToLocalCheckedv8::V8::ToLocalEmpty
  CJS_Runtime::GetValueByNameFromGlobalObject
  CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_libfuzzer_chrome_asan&range=599500:599502

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5479190114336768

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Oct 14

ClusterFuzz has detected this issue as fixed in range 599500:599502.

Detailed report: https://clusterfuzz.com/testcase?key=5479190114336768

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: windows_libfuzzer_chrome_asan
Platform Id: windows

Crash Type: Fatal error
Crash Address: 
Crash State:
  v8::ToLocalCheckedv8::V8::ToLocalEmpty
  CJS_Runtime::GetValueByNameFromGlobalObject
  CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_libfuzzer_chrome_asan&range=599500:599502

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5479190114336768

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment