New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894927 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add horizontal spacing to explore sites page tiles

Project Member Reported by chili@chromium.org, Oct 12

Issue description

The ESP tiles should be farther apart
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f

commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f
Author: Cathy Li <chili@chromium.org>
Date: Fri Oct 12 20:45:57 2018

[Explore sites]: Add more horizontal spacing to tiles.

Bug:  894927 , 867488 
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599339}
[modify] https://crrev.com/3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f/chrome/android/java/res/values/dimens.xml

Status: Fixed (was: Started)
Labels: Merge-Request-71
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 13

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 15

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87455017b2733f06e5d98c25ab0799e78488f1e9

commit 87455017b2733f06e5d98c25ab0799e78488f1e9
Author: Cathy Li <chili@chromium.org>
Date: Mon Oct 15 17:23:50 2018

[Explore sites]: Add more horizontal spacing to tiles.

Bug:  894927 , 867488 
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599339}(cherry picked from commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f)
Reviewed-on: https://chromium-review.googlesource.com/c/1281048
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#23}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/87455017b2733f06e5d98c25ab0799e78488f1e9/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/87455017b2733f06e5d98c25ab0799e78488f1e9/chrome/android/java/res/values/dimens.xml

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/87455017b2733f06e5d98c25ab0799e78488f1e9

Commit: 87455017b2733f06e5d98c25ab0799e78488f1e9
Author: chili@chromium.org
Commiter: chili@chromium.org
Date: 2018-10-15 17:23:50 +0000 UTC

[Explore sites]: Add more horizontal spacing to tiles.

Bug:  894927 , 867488 
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599339}(cherry picked from commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f)
Reviewed-on: https://chromium-review.googlesource.com/c/1281048
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#23}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment