Add information on process to histograms.xml |
||||||
Issue descriptionSummary of action item: Note: speed-metrics-dev@ should own core histograms in histograms.xml (https://cs.chromium.org/codesearch/f/chromium/src/tools/metrics/histograms/histograms.xml?cl=f84eccf86f1e24de806173188513cc2d82e43629) - potentially add information on process.
,
Oct 15
I'm leaning toward speed-metrics-dev: * It's a public list, so external people can escalate easier. * When there's a problem, it gets more eyes with expertise in the metrics and likelihood of having seen metrics changes go by. On the bug that caused this postmortem, I saw people from our team jumping in that I wouldn't have thought to cc, from the speed releasing perspective. * It makes things more consistent, since we can add that list to all our metrics (for example, PageLoad.Internal.PaintTiming.NavigationToFirstContentfulPaint.InitiatingProcess is owned by speed-metrics-dev and not chrome-speed-releasing).
,
Oct 19
Sounds good. Proposed short term text: <histogram...> <owner>speed-metrics-dev@chromium.org</owner> <owner>$CURRENT_OWNER</owner> <summary> Do not modify this metric in any way without contacting speed-metrics-dev@chromium.org. $CURRENT_SUMMARY </summary> </histogram> In the long term, I'd like to add a "For detail see $LINK", that links to our process document. Ushesh, I guess that means the process document should be public. Does this look reasonable?
,
Oct 19
LGTM!
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/217c699b624aab8c63dfa5306bfac8a6de1f00fe commit 217c699b624aab8c63dfa5306bfac8a6de1f00fe Author: Tim Dresser <tdresser@chromium.org> Date: Mon Jan 07 17:49:09 2019 Add instructions on modifying key performance metrics. Bug: 894916 Change-Id: Idcd02a63226ed6a8145b813d25decdc23c1504e6 Reviewed-on: https://chromium-review.googlesource.com/c/1394645 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#620368} [modify] https://crrev.com/217c699b624aab8c63dfa5306bfac8a6de1f00fe/tools/metrics/histograms/histograms.xml
,
Jan 10
This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.
,
Jan 10
,
Jan 11
Issue has a component, but no priority. Updating to have default priority (Pri-2)
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
,
Yesterday
(37 hours ago)
The remainder here is blocked on the rest of the postmortem. I'll follow up with Ushesh on that, but consider this fixed for now. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tdres...@chromium.org
, Oct 15