CommandsApiTest.PageActionOverrideChromeShortcut is flaky in SingleProcessMash |
|||
Issue descriptionThe FYI bot reports an error on CommandsApiTest.PageActionOverrideChromeShortcut. Here is the log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932908805230405008/+/steps/single_process_mash_interactive_ui_tests/0/logs/CommandsApiTest.PageActionOverrideChromeShortcut/0 [ RUN ] CommandsApiTest.PageActionOverrideChromeShortcut [9509:9509:1011/194627.819502:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user [9509:9509:1011/194627.974612:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [9509:9509:1011/194627.997706:ERROR:layer_tree_host_impl.cc(3124)] Forcing zero-copy tile initialization as worker context is missing [9509:9509:1011/194628.008609:ERROR:remote_text_input_client.cc(158)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [9509:9509:1011/194628.008640:ERROR:remote_text_input_client.cc(115)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [9509:9509:1011/194628.008645:ERROR:remote_text_input_client.cc(200)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [9509:9509:1011/194628.008664:ERROR:remote_text_input_client.cc(109)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [9509:9509:1011/194628.008669:ERROR:remote_text_input_client.cc(121)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const [9509:9509:1011/194628.008677:ERROR:remote_text_input_client.cc(176)] Not implemented reached in virtual void RemoteTextInputClient::EnsureCaretNotInRect(const gfx::Rect &) [9509:9509:1011/194628.046353:ERROR:layer_tree_host_impl.cc(3124)] Forcing zero-copy tile initialization as worker context is missing [9509:9509:1011/194628.211419:ERROR:render_widget_host_view_aura.cc(1292)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const [9509:9532:1011/194628.226610:WARNING:simple_synchronous_entry.cc(1251)] Could not open platform files for entry. [9509:9582:1011/194628.263697:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000049613df base::debug::StackTrace::StackTrace() #1 0x00000414a4b5 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f108cbe4cb0 <unknown> #3 0x7f108ccac6d3 epoll_wait #4 0x0000049a370d epoll_dispatch #5 0x0000049a11fc event_base_loop #6 0x0000049800db base::MessagePumpLibevent::Run() #7 0x0000048cce14 base::MessageLoop::Run() #8 0x0000048f4809 base::RunLoop::Run() #9 0x00000887e580 ExtensionTestMessageListener::WaitUntilSatisfied() #10 0x00000097dcab extensions::CommandsApiTest_PageActionOverrideChromeShortcut_Test::RunTestOnMainThread() #11 0x000004149aa2 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #12 0x000003c3f9e8 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #13 0x000003c3e735 ChromeBrowserMainParts::PreMainMessageLoopRun() #14 0x00000295746f chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #15 0x000001c8e51a content::BrowserMainLoop::PreMainMessageLoopRun() #16 0x0000021493a5 content::StartupTaskRunner::RunAllTasksNow() #17 0x000001c8d05a content::BrowserMainLoop::CreateStartupTasks() #18 0x000001c90b70 content::BrowserMainRunnerImpl::Initialize() #19 0x000001c8abd2 content::BrowserMain() #20 0x000003a2d32e content::ContentMainRunnerImpl::Run() #21 0x000005d9ee95 service_manager::Main() #22 0x000003a2b674 content::ContentMain() #23 0x00000414966b content::BrowserTestBase::SetUp() #24 0x000003c2e451 InProcessBrowserTest::SetUp() #25 0x000000c39e5d testing::Test::Run() #26 0x000000c3aa80 testing::TestInfo::Run() #27 0x000000c3af97 testing::TestCase::Run() #28 0x000000c46d67 testing::internal::UnitTestImpl::RunAllTests() #29 0x000000c468dd testing::UnitTest::Run() #30 0x0000048a0be1 base::TestSuite::Run() #31 0x000000a3fa53 InteractiveUITestSuiteRunner::RunTestSuite() #32 0x00000415302c content::LaunchTests() #33 0x000003c286a3 LaunchChromeTests() #34 0x000000a3f9dd main #35 0x7f108cbcff45 __libc_start_main #36 0x0000008fa8aa _start I can see the same error locally. This could be related to issue 891489 but needs a bit more investigation.
,
Oct 15
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74e42e9bf51f8cf07ad995d797c6791432809f25 commit 74e42e9bf51f8cf07ad995d797c6791432809f25 Author: Jun Mukai <mukai@chromium.org> Date: Tue Oct 16 23:56:51 2018 Fix CommandsApiTest flakiness for SingleProcessMash This CL fixes CommandsApiTest.PageActionOverrideChromeShortcut flakiness. This is flaky because the focus of view (OmniboxViewViews in this case) is asynchronous in Mash, it gets done asynchronously after ctrl-l is marked as processed. And actually InputMethodMus marks keyevents before focus (pending keyevents) as done without processing (see https://chromium.googlesource.com/chromium/src/+/master/ui/aura/mus/input_method_mus.cc#172) Considering the test scenario, I believe the test case should wait for the omnibox getting focused. BUG= 894911 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I1e64370924be606badd44ec9fd99c4a39759d28a Reviewed-on: https://chromium-review.googlesource.com/c/1281907 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600197} [modify] https://crrev.com/74e42e9bf51f8cf07ad995d797c6791432809f25/chrome/browser/extensions/extension_keybinding_apitest.cc [modify] https://crrev.com/74e42e9bf51f8cf07ad995d797c6791432809f25/chrome/test/base/interactive_test_utils.h [modify] https://crrev.com/74e42e9bf51f8cf07ad995d797c6791432809f25/chrome/test/base/interactive_test_utils_aura.cc [modify] https://crrev.com/74e42e9bf51f8cf07ad995d797c6791432809f25/chrome/test/base/interactive_test_utils_aura.h [modify] https://crrev.com/74e42e9bf51f8cf07ad995d797c6791432809f25/chrome/test/base/interactive_test_utils_views.cc
,
Oct 17
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/070eec267b13e06aeecec525181f0b49c4f6ef91 commit 070eec267b13e06aeecec525181f0b49c4f6ef91 Author: Jun Mukai <mukai@chromium.org> Date: Tue Oct 23 23:03:52 2018 Revert "Fix CommandsApiTest flakiness for SingleProcessMash" This reverts commit 74e42e9bf51f8cf07ad995d797c6791432809f25. I added this but wasn't the right fix. After the number of fixes for crbug.com/897875 , SendKeyPressSync now waits for the change of focus, so this code isn't necessary anymore. BUG= 894911 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I8b7df7e400d66878e66940f7f676906d935e11f7 Reviewed-on: https://chromium-review.googlesource.com/c/1297410 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602156} [modify] https://crrev.com/070eec267b13e06aeecec525181f0b49c4f6ef91/chrome/browser/extensions/extension_keybinding_apitest.cc [modify] https://crrev.com/070eec267b13e06aeecec525181f0b49c4f6ef91/chrome/test/base/interactive_test_utils.h [modify] https://crrev.com/070eec267b13e06aeecec525181f0b49c4f6ef91/chrome/test/base/interactive_test_utils_aura.cc [modify] https://crrev.com/070eec267b13e06aeecec525181f0b49c4f6ef91/chrome/test/base/interactive_test_utils_aura.h [modify] https://crrev.com/070eec267b13e06aeecec525181f0b49c4f6ef91/chrome/test/base/interactive_test_utils_views.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by mukai@chromium.org
, Oct 12