platform_AddPrinter doesn't log why cmp failed |
||
Issue descriptionplatform_AddPrinter fails with an exception instead of a test error when cmp fails because the default behavior for utils.system_output is to throw an exception when the program it's running returns a non-zero exit code.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b543473d0fdd873aca46d51e364bb61305f65876 commit b543473d0fdd873aca46d51e364bb61305f65876 Author: Sean Kau <skau@chromium.org> Date: Thu Oct 18 21:53:41 2018 platform_AddPrinter: Expect cmp to fail Expect cmp to fail when comparing outputs so that we can log the diff. The test will fail with a test failure instead of an exception now. BUG= chromium:894908 TEST=test_that ... platform_AddPrinter.generic platform_AddPrinter.epson also run with a different golden file to force failure. Change-Id: If9f91089b8b1a08d2a080527d09cb1cf9745bcf6 Reviewed-on: https://chromium-review.googlesource.com/1278356 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sean Kau <skau@chromium.org> Reviewed-by: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by: Kalin Stoyanov <kalin@chromium.org> [modify] https://crrev.com/b543473d0fdd873aca46d51e364bb61305f65876/client/site_tests/platform_AddPrinter/platform_AddPrinter.py
,
Oct 18
|
||
►
Sign in to add a comment |
||
Comment 1 by ka...@chromium.org
, Oct 12