New issue
Advanced search Search tips

Issue 894907 link

Starred by 1 user
Status: Started
Owner:
katie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocked on:
issue 915861


Sign in to add a comment

Implement dwell control

Project Member Reported by katie@chromium.org, Oct 12 
Supporting mouse-only users who cannot perform standard clicks by updating the Autoclick Accessibility feature to be a full Dwell Control, allowing users to change the action performed by dwell instead of always clicking, and adding additional user settings for customization. This provides support for current and future eye-tracking and head-tracking input devices.

go/chromeos-dwell-design
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5da04ae848db780dd6d5b7a209fa897c94b80d3

commit b5da04ae848db780dd6d5b7a209fa897c94b80d3
Author: Katie D <katie@chromium.org>
Date: Wed Oct 24 00:39:17 2018

Add Autoclick types to settings page behind a11y flag.

Implements right-click, double-click, and no action; left-click
was already implemented. Does not implement drag-and-drop.
Adds unit tests for newly implemented click types.

New strings share a screenshot hash because all strings could be
captured in a single screenshot.

See go/chromeos-dwell-design for more about autoclick and dwell
control plans.

Bug: 894907
Change-Id: If045ab1d3b9e2771d347963d5b17bdaf06362853
Reviewed-on: https://chromium-review.googlesource.com/c/1287191
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602188}
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/autoclick/autoclick_controller.h
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/public/cpp/ash_constants.h
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/ash/public/interfaces/accessibility_controller.mojom
[add] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_EVENT_TYPE_DOUBLE_CLICK.png.sha1
[add] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_EVENT_TYPE_DRAG_AND_DROP.png.sha1
[add] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_EVENT_TYPE_LABEL.png.sha1
[add] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_EVENT_TYPE_LEFT_CLICK.png.sha1
[add] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_EVENT_TYPE_NO_ACTION.png.sha1
[add] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_EVENT_TYPE_RIGHT_CLICK.png.sha1
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/browser/prefs/pref_service_incognito_whitelist.cc
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
[modify] https://crrev.com/b5da04ae848db780dd6d5b7a209fa897c94b80d3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d2668b075eb5f3efb4a0f8a0aded3e97eca9d0

commit 74d2668b075eb5f3efb4a0f8a0aded3e97eca9d0
Author: Katie D <katie@chromium.org>
Date: Wed Oct 24 21:39:17 2018

Add user action metrics for dwell control.

Adds user action logging for dwell action types.
Changes dwell delay logging so that it is logged each time
the user changes the delay pref. It will still be logged
when the AutoclickController starts, so we should still get
events at startup as well.

Bug: 894907
Change-Id: Iedcf7c40385e58e1e29e354870f5c839c5c715c7
Reviewed-on: https://chromium-review.googlesource.com/c/1287265
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602465}
[modify] https://crrev.com/74d2668b075eb5f3efb4a0f8a0aded3e97eca9d0/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/74d2668b075eb5f3efb4a0f8a0aded3e97eca9d0/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/74d2668b075eb5f3efb4a0f8a0aded3e97eca9d0/tools/metrics/actions/actions.xml
[modify] https://crrev.com/74d2668b075eb5f3efb4a0f8a0aded3e97eca9d0/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf8d559320710ab93f025c9dd8da3eb692be4915

commit cf8d559320710ab93f025c9dd8da3eb692be4915
Author: Katie D <katie@chromium.org>
Date: Wed Oct 24 23:01:22 2018

Supports drag and drop actions with Autoclick.

This works by starting the drag on the first dwell
and ending the drag on the second dwell, and rewriting
mouse moved events to mouse dragged events in between.

This is still hidden behind the accessibility flag.

Bug: 894907
Change-Id: Ia2cd72053e3d1023711764e2b581caa686f2fb98
Reviewed-on: https://chromium-review.googlesource.com/c/1295250
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602512}
[modify] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/BUILD.gn
[modify] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/autoclick/autoclick_controller.h
[add] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/autoclick/autoclick_drag_event_rewriter.cc
[add] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/autoclick/autoclick_drag_event_rewriter.h
[add] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/autoclick/autoclick_drag_event_rewriter_unittest.cc
[modify] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/cf8d559320710ab93f025c9dd8da3eb692be4915/ash/shell.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c

commit 07a08f0e06a95ca064fb78344e47ec5e69c0ff5c
Author: Katie D <katie@chromium.org>
Date: Thu Oct 25 22:57:07 2018

Add a user-facing setting to revert to left click after autoclick action.

This is still hidden behind the accessibility features flag.
For more, see go/chromeos-dwell-design.

Bug: 894907
Change-Id: I8566f2e46e3703c56ede43e6efa8f8b4cbd97abb
Reviewed-on: https://chromium-review.googlesource.com/c/1297575
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602914}
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/autoclick/autoclick_controller.h
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/autoclick/autoclick_drag_event_rewriter.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/ash/public/cpp/ash_pref_names.h
[add] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_REVERT_TO_LEFT_CLICK.png.sha1
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/browser/prefs/pref_service_incognito_whitelist.cc
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/07a08f0e06a95ca064fb78344e47ec5e69c0ff5c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7e5d8fbafd62e1f69669e04ceb864f6ecf1aab9

commit d7e5d8fbafd62e1f69669e04ceb864f6ecf1aab9
Author: Katie D <katie@chromium.org>
Date: Mon Oct 29 23:12:45 2018

Make drag & drop work on chromebooks with touchpads.

Drag & drop worked with an external mouse but failed on touchpad
devices, specifically Eve and Nocturne.

Touchpads generate ET_SCROLL_FLING_CANCEL events at the start of
a drag. This change has the AutoclickDragEventRewriter ignore
those events, which fixes behavior on the touchpads of nocturne
and eve.

Also resolves a TODO to ensure that drag & drops are completed
rather than leaving the UI in an odd state by not including the
mouse released event.

Finally, logs UMA only once per drag-and-drop.

Bug: 894907
Change-Id: I79cc178e701894881618514a0e3aa585721a2c41
Reviewed-on: https://chromium-review.googlesource.com/c/1306295
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603679}
[modify] https://crrev.com/d7e5d8fbafd62e1f69669e04ceb864f6ecf1aab9/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/d7e5d8fbafd62e1f69669e04ceb864f6ecf1aab9/ash/autoclick/autoclick_controller.h
[modify] https://crrev.com/d7e5d8fbafd62e1f69669e04ceb864f6ecf1aab9/ash/autoclick/autoclick_drag_event_rewriter.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/093241823e0f8c29889ab9ab8525faeddaf48dd7

commit 093241823e0f8c29889ab9ab8525faeddaf48dd7
Author: Katie D <katie@chromium.org>
Date: Fri Nov 09 19:37:01 2018

Adds autoclick mouse movement threshold to user settings.

Uses a drop-down rather than a slider or text field because
this seems like it would be easier for Autoclick users to
activate.

This still needs UI review but is hidden behind the
--enable_experimental_accessibility_features flag.

Bug: 894907
Change-Id: If4de66488df32ea2929961159ebfdaad15216f55
Reviewed-on: https://chromium-review.googlesource.com/c/1324376
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606934}
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/autoclick/autoclick_controller.h
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/public/cpp/ash_constants.h
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/ash/public/cpp/ash_pref_names.h
[add] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_MOVEMENT_THRESHOLD_DEFAULT.png.sha1
[add] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_MOVEMENT_THRESHOLD_EXTRA_LARGE.png.sha1
[add] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_MOVEMENT_THRESHOLD_EXTRA_SMALL.png.sha1
[add] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_MOVEMENT_THRESHOLD_LABEL.png.sha1
[add] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_MOVEMENT_THRESHOLD_LARGE.png.sha1
[add] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/chromeos_strings_grdp/IDS_SETTINGS_AUTOCLICK_MOVEMENT_THRESHOLD_SMALL.png.sha1
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/app/settings_strings.grdp
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/browser/prefs/pref_service_incognito_whitelist.cc
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
[modify] https://crrev.com/093241823e0f8c29889ab9ab8525faeddaf48dd7/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 7 by katie@chromium.org, Dec 17

Blockedon: 915861
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d528ced7d4fe7290eab7d42c1b04b19327327d6c

commit d528ced7d4fe7290eab7d42c1b04b19327327d6c
Author: Katie D <katie@chromium.org>
Date: Sat Jan 05 00:45:22 2019

Adds an autoclick button and menu to the tray behind a flag.

Autoclick menu allows users to change which type of automatic
click action will happen after the autoclick time elapses, directly
from the tray. The menu also has a shortcut to jump to the automatic
clicks settings page.

This is part of the new autoclick feature set. See more UI details
at go/cros-dwell-ux. Some UX is still in flux.

Assets are not completed and some other TODOs exist, but this menu
is hidden behind a flag. All TODOs will be completed before launch!

Bug: 894907
Change-Id: I9207f13d75101afdf8bc18ca704000e7a89e9c9a
Reviewed-on: https://chromium-review.googlesource.com/c/1391851
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620130}
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/BUILD.gn
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings.grd
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_AUTOCLICK_TRAY_ACCESSIBLE_NAME.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_ACCESSIBILITY_AUTOCLICK.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOCLICK_OPTION_DOUBLE_CLICK.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOCLICK_OPTION_DRAG_AND_DROP.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOCLICK_OPTION_LEFT_CLICK.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOCLICK_OPTION_NO_ACTION.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOCLICK_OPTION_RIGHT_CLICK.png.sha1
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOCLICK_SETTINGS.png.sha1
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/autoclick/autoclick_controller.h
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray.cc
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray.h
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray_action_list_view.cc
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray_action_list_view.h
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray_action_view.cc
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray_action_view.h
[add] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/accessibility/autoclick_tray_unittest.cc
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/status_area_widget.cc
[modify] https://crrev.com/d528ced7d4fe7290eab7d42c1b04b19327327d6c/ash/system/status_area_widget.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02deea50cf479a285995cf3538b4e6e265d5a6f6

commit 02deea50cf479a285995cf3538b4e6e265d5a6f6
Author: Katie D <katie@chromium.org>
Date: Mon Jan 07 18:09:12 2019

Make autoclick always left-click on its own tray.

This ensures that autoclick users cannot get locked out of changing
autoclick state because they can always left-click on the autoclick
tray button to change from pause, right-click, etc.

Bug: 894907
Change-Id: I935383b7c03dca0ce9bf31951455a0554706ab62
Reviewed-on: https://chromium-review.googlesource.com/c/1392277
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620376}
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray.cc
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray.h
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray_action_list_view.cc
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray_action_list_view.h
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray_action_view.cc
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray_action_view.h
[modify] https://crrev.com/02deea50cf479a285995cf3538b4e6e265d5a6f6/ash/system/accessibility/autoclick_tray_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0

commit 51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0
Author: Katie D <katie@chromium.org>
Date: Mon Jan 07 18:22:13 2019

Adds UMA user action metrics for Autoclick tray menu.

Also updates existing Autoclick user action metrics to use suffixes.

Bug: 894907
Change-Id: I4b6f23ce143e4803045d196c54e6e2beea021cab
Reviewed-on: https://chromium-review.googlesource.com/c/1391854
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620385}
[modify] https://crrev.com/51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0/ash/system/accessibility/autoclick_tray.cc
[modify] https://crrev.com/51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0/tools/metrics/actions/actions.xml
[modify] https://crrev.com/51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/51bd9783a2d0e8f0d8126ca0499efeda4fcfa6f0/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment