Blurry and broken vector icons with GPU rasterization |
||||||||||
Issue descriptionEnabling GPU rasterization for the UI results in blurry and broken vector icons in certain places. It feels like the icon bitmaps have been rescaled.
,
Oct 12
Enabling the flag for UsePaintRecordForImageSkia fixes the issue. Landing a change to enable the flag by default on Chrome OS.
,
Oct 12
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13657ca1e89d716d4566085fee50e8fe83ab5cc7 commit 13657ca1e89d716d4566085fee50e8fe83ab5cc7 Author: Malay Keshav <malaykeshav@chromium.org> Date: Fri Oct 12 23:53:15 2018 Enable UsePaintRecordForImageSkia for Chrome OS GPU rasterization for Chrome OS is being enabled but it causes a regression in the rendering of vector icons at fractional scales most likely due to its interaction with Pixel Canvas. It seems like the vector icons are being rescaled after rasterization to get the correct scale images. This results in the broken and blurry icon bitmaps. Using PaintRecords instead of rasterized bitmaps fixes this bug, as scaling on PaintRecords is sharp. Bug: 894901 Change-Id: I1cd541927b7aaa032780b15d66df2a69f45c18e4 Component: Images, vector icons, Chrome OS Reviewed-on: https://chromium-review.googlesource.com/c/1279068 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#599423} [modify] https://crrev.com/13657ca1e89d716d4566085fee50e8fe83ab5cc7/ui/gfx/switches.cc
,
Oct 12
,
Oct 16
,
Oct 16
The merge request for m71 is only for Chrome OS. Other platforms will not be affected.
,
Oct 16
,
Oct 17
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9467f94c9c7ac2e639391c94464088281c2a9adf commit 9467f94c9c7ac2e639391c94464088281c2a9adf Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Oct 17 20:24:02 2018 [m71] Enable UsePaintRecordForImageSkia for CrOS on M71 We have UsePaintRecordForImageSkia feature enabled for all platforms post m72. But this flag needs to be enabled for CrOS on m71 as ui-GPU rasterization for CrOS is being enabled in this milestone. The master branch change can be found here: https://chromium-review.googlesource.com/c/chromium/src/+/1279068 Bug: 894901 Change-Id: Iffc5ba99727aa155b7a6237ccab917fe6d7e0659 Component: Images, vector icons, Chrome OS Reviewed-on: https://chromium-review.googlesource.com/c/1281237 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#96} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9467f94c9c7ac2e639391c94464088281c2a9adf/ui/gfx/switches.cc
,
Oct 17
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9467f94c9c7ac2e639391c94464088281c2a9adf Commit: 9467f94c9c7ac2e639391c94464088281c2a9adf Author: malaykeshav@chromium.org Commiter: malaykeshav@chromium.org Date: 2018-10-17 20:24:02 +0000 UTC [m71] Enable UsePaintRecordForImageSkia for CrOS on M71 We have UsePaintRecordForImageSkia feature enabled for all platforms post m72. But this flag needs to be enabled for CrOS on m71 as ui-GPU rasterization for CrOS is being enabled in this milestone. The master branch change can be found here: https://chromium-review.googlesource.com/c/chromium/src/+/1279068 Bug: 894901 Change-Id: Iffc5ba99727aa155b7a6237ccab917fe6d7e0659 Component: Images, vector icons, Chrome OS Reviewed-on: https://chromium-review.googlesource.com/c/1281237 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#96} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by malaykeshav@chromium.org
, Oct 12132 KB
132 KB View Download
142 KB
142 KB View Download