New issue
Advanced search Search tips

Issue 894897 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Run and fix autotest on M71 release

Project Member Reported by zentaro@chromium.org, Oct 12

Issue description

Update the Mount proto based on new NTLM change and verify that the updated autotest passes on the M71 release.
 
Components: Platform>Apps>FileManager Enterprise
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4

commit 19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4
Author: jimmy <jimmyxgong@google.com>
Date: Thu Oct 18 17:55:41 2018

autotest: Add MountConfigProto to Mount in SmbProvider autotest

- Updated smbprovider autotest to support the new MountConfigProto for
  mounting.
- Fixed error with opening files (files with id 0 are good, previously
  treated as a bad value).

BUG= chromium:894897 
TEST=autotest

Change-Id: I09f34575357040ab1ad5688369b7593f85fda278
Reviewed-on: https://chromium-review.googlesource.com/1279326
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
[modify] https://crrev.com/19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4/client/common_lib/cros/smbprovider.py

Status: Fixed (was: Started)
Labels: Merge-Request-71
Limited to the autotests?  No production risk?
This is only limited to autotests and are manually ran. No production risk
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 23

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 23

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c276bcc25ffe791676c2488c9fb24ce8359f2eec

commit c276bcc25ffe791676c2488c9fb24ce8359f2eec
Author: jimmy <jimmyxgong@google.com>
Date: Tue Oct 23 18:53:09 2018

autotest: Add MountConfigProto to Mount in SmbProvider autotest

- Updated smbprovider autotest to support the new MountConfigProto for
  mounting.
- Fixed error with opening files (files with id 0 are good, previously
  treated as a bad value).

BUG= chromium:894897 
TEST=autotest

Change-Id: I09f34575357040ab1ad5688369b7593f85fda278
Reviewed-on: https://chromium-review.googlesource.com/1279326
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
(cherry picked from commit 19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4)
Reviewed-on: https://chromium-review.googlesource.com/c/1296854
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/c276bcc25ffe791676c2488c9fb24ce8359f2eec/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
[modify] https://crrev.com/c276bcc25ffe791676c2488c9fb24ce8359f2eec/client/common_lib/cros/smbprovider.py

Hi Jimmy,
Could you please provide steps to verify the fix. Thanks.!
Status: Verified (was: Fixed)
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 29

Cc: baileyberro@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Nov 2

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment