Run and fix autotest on M71 release |
|||||||
Issue descriptionUpdate the Mount proto based on new NTLM change and verify that the updated autotest passes on the M71 release.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4 commit 19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4 Author: jimmy <jimmyxgong@google.com> Date: Thu Oct 18 17:55:41 2018 autotest: Add MountConfigProto to Mount in SmbProvider autotest - Updated smbprovider autotest to support the new MountConfigProto for mounting. - Fixed error with opening files (files with id 0 are good, previously treated as a bad value). BUG= chromium:894897 TEST=autotest Change-Id: I09f34575357040ab1ad5688369b7593f85fda278 Reviewed-on: https://chromium-review.googlesource.com/1279326 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py [modify] https://crrev.com/19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4/client/common_lib/cros/smbprovider.py
,
Oct 18
,
Oct 22
,
Oct 23
Limited to the autotests? No production risk?
,
Oct 23
This is only limited to autotests and are manually ran. No production risk
,
Oct 23
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c276bcc25ffe791676c2488c9fb24ce8359f2eec commit c276bcc25ffe791676c2488c9fb24ce8359f2eec Author: jimmy <jimmyxgong@google.com> Date: Tue Oct 23 18:53:09 2018 autotest: Add MountConfigProto to Mount in SmbProvider autotest - Updated smbprovider autotest to support the new MountConfigProto for mounting. - Fixed error with opening files (files with id 0 are good, previously treated as a bad value). BUG= chromium:894897 TEST=autotest Change-Id: I09f34575357040ab1ad5688369b7593f85fda278 Reviewed-on: https://chromium-review.googlesource.com/1279326 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> (cherry picked from commit 19d5cbfed29c0bda75c099f31668c6a8eb3ae0c4) Reviewed-on: https://chromium-review.googlesource.com/c/1296854 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/c276bcc25ffe791676c2488c9fb24ce8359f2eec/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py [modify] https://crrev.com/c276bcc25ffe791676c2488c9fb24ce8359f2eec/client/common_lib/cros/smbprovider.py
,
Oct 25
Hi Jimmy, Could you please provide steps to verify the fix. Thanks.!
,
Oct 25
Hey, SMB autotest was ran locally and verified that it is fixed and passes all test cases. This is the autotest code: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py?q=smbproviderda&sq=package:%5Echromeos_public$&g=0&l=1
,
Oct 25
,
Oct 29
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuckley@google.com
, Oct 12