New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894892 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Refactor link click handling in OOBE start screen

Project Member Reported by hansberry@chromium.org, Oct 12

Issue description

2 links are contained in the setup flow's message body, (e.g., [1]). In OOBE, because the browser can't open links (because it can't display in front of OOBE), we display a webview overlay instead, and to do that we've had to hackily reach into the message bodies and attach onclick listeners to the links via JS. See the CL that introduced this for more [2].

This is confusing and roundabout -- we should investigate a way to make this code more clear.

1) https://cs.chromium.org/chromium/src/chrome/app/chromeos_strings.grdp?q=%22Your+Chromebook+and+Android+phone%22&sq=package:chromium&g=0&l=172
2) https://chromium-review.googlesource.com/c/chromium/src/+/1275296
 

Sign in to add a comment