New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 13
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: ErrorPageAutoReloadTest.ManualReloadNotSuppressed



Sign in to add a comment

ErrorPageAutoReloadTest.ManualReloadNotSuppressed is flaky

Project Member Reported by Findit, Oct 12

Issue description

Cc: khorimoto@chromium.org jlklein@chromium.org mmenke@chromium.org
Hey Matt - any ideas here? It looks like you wrote this test originally, but it hasn't been edited in almost a year.

I'm not sure how my change would have caused an issue here, but perhaps there's some subtle interaction I haven't figured out. Do you know when we would expect a failure like this to happen?

Example failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932858848815843632/+/steps/viz_browser_tests/0/logs/ErrorPageAutoReloadTest.IgnoresSameDocumentNavigation/0
Labels: -Sheriff-Chromium
Owner: khorimoto@chromium.org
Status: Assigned (was: Untriaged)
Moving this out from sheriff's queue. Please feel free to move it back if sheriff's attention is needed.
Owner: mmenke@chromium.org
Assigning to mmenke@ for now until we get more clarity about the issue.
It looks to me like the test displays a network error page, which should trigger an auto-reload, and waits for that reload to succeed.

At that point, the renderer process (NetErrorHelperCore, specifically) starts a 5 second timer to try and reload the page again, but the test interrupts it with a manual reload (Which should interrupt the timer, and show yet another error page).  It looks like the ui_test_utils::NavigateToURLBlockUntilNavigationsComplete call on line 1107 is somehow wait until that 5 second timer has completed, and the second auto-reload attempt has completed (and failed).

I am a bit confused as to why kRequestsToFail is 3, and not 2, since I count only two failing requests.
Owner: ----
Status: Available (was: Assigned)
Punting out of my queue (to reflect the fact that I'm not actively looking into this, though happy to help poke at it).
 Issue 894902  has been merged into this issue.
Talked to khorimoto about this.  The issue is likely that the feature in question is issuing network requests to a google URL by default.  All hostnames are mapped to localhost in tests, so we're trying to establish an HTTPS connection to localhost, which we probably shouldn't be doing.  In addition, that particular test is intercepting requests without checking the hostname.  We could modify the test, but I actually think we want to not be sending out extra network requests to localhost, and hope they don't do anything weird, in browser tests.
Owner: khorimoto@chromium.org
Status: Started (was: Available)
Fix in review: https://chromium-review.googlesource.com/c/chromium/src/+/1279067
 Issue 894950  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2868aaedd272b1f32c002076960f95386caa8ba

commit b2868aaedd272b1f32c002076960f95386caa8ba
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Oct 13 00:13:44 2018

[CrOS MultiDevice] Reland: Enable multi-device features during OOBE.

Original CL (uploaded as patchset 1):
https://chromium-review.googlesource.com/c/chromium/src/+/1260491

Revert CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1277577

Fix for reland:
To ensure that no unnecessary network requests are made, I used a fake
DeviceSync implementation for browser_tests, which I included in
patchset 2.


Original CL description:
This CL enables several multi-device flags by default. This resulted in
lots of broken tests, so this CL also fixes those broken tests.

Instant Tethering is enabled via Finch flags; however, Finch does not
immediately enable/disable features. Instead, when a user logs in, a
Finch configuration is downloaded and is applied the next time the user
logs in. Thus, to ensure that these features are available during OOBE,
this CL overrides multi-device feature experiments during the first
run. On subsequent logins, the Finch feature list will be applied.

Bug:  884066 ,  894882 
Change-Id: I879b903762f605d93eb6c9b1c709e0a4313903ef
TBR: asvitkine@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1279067
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599432}
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/BUILD.gn
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/android_sms/android_sms_service_factory.h
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/device_sync/device_sync_client_factory.h
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/login/hid_detection_browsertest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.h
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/tether/tether_service_factory.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/tether/tether_service_factory.h
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/test/BUILD.gn
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/chromeos_features.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/connection_preserver_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/host_connection_metrics_logger_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/host_scanner_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/components/tether/tether_connector_impl_unittest.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/services/multidevice_setup/DEPS
[modify] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/services/multidevice_setup/public/cpp/BUILD.gn
[add] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/services/multidevice_setup/public/cpp/first_run_field_trial.cc
[add] https://crrev.com/b2868aaedd272b1f32c002076960f95386caa8ba/chromeos/services/multidevice_setup/public/cpp/first_run_field_trial.h

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 13

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f374b85c7c6b0c8fbb2ee16c02391619f28365f

commit 9f374b85c7c6b0c8fbb2ee16c02391619f28365f
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Oct 13 00:40:36 2018

[CrOS MultiDevice] Reland: Enable multi-device features during OOBE.

Original CL (uploaded as patchset 1):
https://chromium-review.googlesource.com/c/chromium/src/+/1260491

Revert CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1277577

Fix for reland:
To ensure that no unnecessary network requests are made, I used a fake
DeviceSync implementation for browser_tests, which I included in
patchset 2.


Original CL description:
This CL enables several multi-device flags by default. This resulted in
lots of broken tests, so this CL also fixes those broken tests.

Instant Tethering is enabled via Finch flags; however, Finch does not
immediately enable/disable features. Instead, when a user logs in, a
Finch configuration is downloaded and is applied the next time the user
logs in. Thus, to ensure that these features are available during OOBE,
this CL overrides multi-device feature experiments during the first
run. On subsequent logins, the Finch feature list will be applied.

Bug:  884066 ,  894882 
Change-Id: I879b903762f605d93eb6c9b1c709e0a4313903ef
TBR: asvitkine@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1279067
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599432}(cherry picked from commit b2868aaedd272b1f32c002076960f95386caa8ba)
Reviewed-on: https://chromium-review.googlesource.com/c/1279361
Cr-Commit-Position: refs/branch-heads/3578@{#9}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/BUILD.gn
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/android_sms/android_sms_service_factory.h
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/device_sync/device_sync_client_factory.h
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/login/hid_detection_browsertest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.h
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/tether/tether_service_factory.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/tether/tether_service_factory.h
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/test/BUILD.gn
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/chromeos_features.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/connection_preserver_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/host_connection_metrics_logger_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/host_scanner_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/components/tether/tether_connector_impl_unittest.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/services/multidevice_setup/DEPS
[modify] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/services/multidevice_setup/public/cpp/BUILD.gn
[add] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/services/multidevice_setup/public/cpp/first_run_field_trial.cc
[add] https://crrev.com/9f374b85c7c6b0c8fbb2ee16c02391619f28365f/chromeos/services/multidevice_setup/public/cpp/first_run_field_trial.h

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/9f374b85c7c6b0c8fbb2ee16c02391619f28365f

Commit: 9f374b85c7c6b0c8fbb2ee16c02391619f28365f
Author: khorimoto@google.com
Commiter: jlklein@chromium.org
Date: 2018-10-13 00:40:36 +0000 UTC

[CrOS MultiDevice] Reland: Enable multi-device features during OOBE.

Original CL (uploaded as patchset 1):
https://chromium-review.googlesource.com/c/chromium/src/+/1260491

Revert CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1277577

Fix for reland:
To ensure that no unnecessary network requests are made, I used a fake
DeviceSync implementation for browser_tests, which I included in
patchset 2.


Original CL description:
This CL enables several multi-device flags by default. This resulted in
lots of broken tests, so this CL also fixes those broken tests.

Instant Tethering is enabled via Finch flags; however, Finch does not
immediately enable/disable features. Instead, when a user logs in, a
Finch configuration is downloaded and is applied the next time the user
logs in. Thus, to ensure that these features are available during OOBE,
this CL overrides multi-device feature experiments during the first
run. On subsequent logins, the Finch feature list will be applied.

Bug:  884066 ,  894882 
Change-Id: I879b903762f605d93eb6c9b1c709e0a4313903ef
TBR: asvitkine@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1279067
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599432}(cherry picked from commit b2868aaedd272b1f32c002076960f95386caa8ba)
Reviewed-on: https://chromium-review.googlesource.com/c/1279361
Cr-Commit-Position: refs/branch-heads/3578@{#9}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment