[Query in Omnibox] Secure Chip disappears after clicking on it |
|||
Issue descriptionChrome Version: Canary 71.0.3578.0 OS: macOS, but probably OS=All What steps will reproduce the problem? (1) Enable chrome://flags/#enable-query-in-omnibox (2) Visit any page (3) Click on the Lock icon What is the expected result? Lock Icon should keep there and the Menu should appear. What happens instead? URL expands, Lock icon disappears and the Menu appears. A screencast is attached. Thanks for looking into this issue. Mehmet
,
Oct 12
Great, thanks :-) One more thing I noticed: When you click on the Lock icon to show the menu, pressing on the ESC-Key dismisses the menu but with a second press on the ESC-Key it would be nice to bring back the Lock icon. Currently it keeps the expanded URL in the Omnibox and doesnât react on the second ESC-key pressing.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d82637f008ac74a3ae81c7fc9cf3a15638cf6ba commit 3d82637f008ac74a3ae81c7fc9cf3a15638cf6ba Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Nov 14 18:12:00 2018 Omnibox: Query in Omnibox - Remove Page Info unelision on Desktop Removes the page info popup triggering unelision on Desktop. Users found it more surprising than useful. We are adding other, more explicit methods of unelision. This CL is a simple revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1265497 Bug: 874592, 894862 Change-Id: Ia1ebc7de91bb69f0aac9df22235b4ea24e7c0e93 Reviewed-on: https://chromium-review.googlesource.com/c/1332266 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#608037} [modify] https://crrev.com/3d82637f008ac74a3ae81c7fc9cf3a15638cf6ba/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Nov 15
Able to reproduce the issue on chrome version# 71.0.3578.0 using Mac 10.14 by following steps as per comment#0. Verified the fix on Mac 10.14, Ubuntu 17.10 and Windows 10 as per comment#0 on latest chrome version #72.0.3611.0. Attaching screencast for reference. Observed that secure chip does not disappear. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jan 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tommycli@chromium.org
, Oct 12Status: Assigned (was: Untriaged)