New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894859 link

Starred by 1 user
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Build-Toolchain

Blocking:
issue 834385



Sign in to add a comment

webrtc-apm: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Oct 12 
With glibc 2.27
emerge-samus webrtc-apm

In file included from rtc_base/location.cc:13:
./rtc_base/stringutils.h:180:39: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  int len = vsnprintf(buffer, buflen, format, args);
                                      ^~~~~~
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/d8c4b7bf1865359b974e48b65030da86bf1bed8d

commit d8c4b7bf1865359b974e48b65030da86bf1bed8d
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Oct 13 18:42:20 2018

rtc_base: fix -Wformat-nonliteral warning

This fixes  -Wformat-nonliteral when building with glibc 2.27

BUG= chromium:894859 
TEST=emerge-samus webrtc-apm with glibc 2.27

Change-Id: I9db84c2146b2bb366e07d9d54546d91bf3a6713d
Reviewed-on: https://chromium-review.googlesource.com/1277980
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d8c4b7bf1865359b974e48b65030da86bf1bed8d/rtc_base/stringutils.h

Comment 2 by yunlian@chromium.org, Oct 24

Status: Verified (was: Untriaged)
►

Sign in to add a comment