New issue
Advanced search Search tips

Issue 894853 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Multi-window resizer widget is not hidden when switching profiles

Project Member Reported by varkha@chromium.org, Oct 12

Issue description

Chrome Version: 70.0.3538.41
OS: Chrome OS

What steps will reproduce the problem?
(1) In a multi-profile signed in setup have 2 side-by-side touching windows.
(2) Position mouse pointer at the edge between the windows to get the split resizer
(3) Use Alt+Ctrl+. to switch profiles

What is the expected result?
The resizer widget gets hidden.

What happens instead?
Split resizer is still visible in a seemingly unrelated place.

Related code should be at https://cs.chromium.org/chromium/src/ash/wm/workspace/multi_window_resize_controller.*
 
Screenshot 2018-10-12 at 11.38.27 AM.png
24.0 KB View Download
Components: -UI -UI>Shell>WindowManager UI>Shell>WindowManager>Splitscreen
Cc: -x...@chromium.org
Owner: x...@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c2801499ff7a9ebed9460105175d3bc39399a0a

commit 3c2801499ff7a9ebed9460105175d3bc39399a0a
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Oct 16 23:18:56 2018

Hide the multi-window resizer if the resized window is hidden.

If one of the resized windows is hidden (visibility changes to hidden),
the multi-window resizer should also be hidden.

Bug:  894853 
Change-Id: I77c8c5e831a85a6e66edb35381778d92e97cc856
Reviewed-on: https://chromium-review.googlesource.com/c/1282027
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600181}
[modify] https://crrev.com/3c2801499ff7a9ebed9460105175d3bc39399a0a/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/3c2801499ff7a9ebed9460105175d3bc39399a0a/ash/wm/workspace/multi_window_resize_controller.h
[modify] https://crrev.com/3c2801499ff7a9ebed9460105175d3bc39399a0a/ash/wm/workspace/multi_window_resize_controller_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment