New issue
Advanced search Search tips

Issue 894851 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Set COMPONENT in safe_browsing/**/OWNERS

Project Member Reported by nparker@chromium.org, Oct 12

Issue description

Various crash/bug analysis tools use the "# COMPONENT:" line in OWNERS files to assign bug components. We should fix these for safe_browsing/* files. ref:  https://crbug.com/679905 

# COMPONENT: Services>Safebrowsing


https://cs.chromium.org/search/?q=f:OWNERS++f:safe_browsing&sq=package:chromium&type=cs
 
Labels: SafeBrowsing-Triaged
Owner: nparker@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b318a844cbcf2f0d949eaa197c94d3115d1322ab

commit b318a844cbcf2f0d949eaa197c94d3115d1322ab
Author: Nathan Parker <nparker@chromium.org>
Date: Tue Nov 06 21:12:17 2018

Clean up safe_browsing OWNERS files

* Remove jialiul@ (has left Chrome)
* Add drubery@ to a few dirs where he's the expert now
* Add COMPONENT info to all of them
* Other misc cleanups

Bug:  894851 
Change-Id: I60e6b0f8651486a656363fe2b215b1451ae75615
Reviewed-on: https://chromium-review.googlesource.com/c/1318909
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605823}
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/browser/extensions/api/safe_browsing_private/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/browser/resources/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/browser/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/browser/ui/views/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/browser/ui/webui/reset_password/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/common/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/renderer/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/chrome/utility/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/components/safe_browsing/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/components/safe_browsing/common/OWNERS
[modify] https://crrev.com/b318a844cbcf2f0d949eaa197c94d3115d1322ab/components/security_interstitials/OWNERS

Status: Fixed (was: Untriaged)

Sign in to add a comment