New issue
Advanced search Search tips

Issue 894848 link

Starred by 2 users
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Oct 24
Cc:
droger@chromium.org
ew...@chromium.org
msramek@chromium.org
tangltom@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Updated cookie and history text on advanced CBD tab when the sync state changes.

Project Member Reported by dullweber@chromium.org, Oct 12 
Chrome Version: 71.0.3573.0
OS: Linux

Unlike the cookie text on the basic tab, the checkbox on the advanced tab doesn't update dynamically when the sync/signin status is changed.

As you can pause sync directly from CBD now, we should make sure that the text is updated correctly.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed74c1dd6bb2e796421bf2b0a75343a96dec2912

commit ed74c1dd6bb2e796421bf2b0a75343a96dec2912
Author: Christian Dullweber <dullweber@chromium.org>
Date: Wed Oct 24 12:15:04 2018

Track sync changes and update cookie notice

Dynamically update the cookie notice on the advanced tab when sync state
changes.

Bug:  894848 
Change-Id: I62d507d41a1bd91d37738f2d68d00427bd2bb386
Reviewed-on: https://chromium-review.googlesource.com/c/1293451
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602306}
[modify] https://crrev.com/ed74c1dd6bb2e796421bf2b0a75343a96dec2912/chrome/browser/browsing_data/counters/site_data_counter.cc
[modify] https://crrev.com/ed74c1dd6bb2e796421bf2b0a75343a96dec2912/chrome/browser/browsing_data/counters/site_data_counter.h

Comment 2 by dullweber@google.com, Oct 24

Status: Fixed (was: Assigned)
The history text already works correctly
►

Sign in to add a comment