New issue
Advanced search Search tips

Issue 894837 link

Starred by 1 user
Status: Verified
Owner:
martijnb@chromium.org
Closed: Oct 18
Cc:
pschaffner@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Dynamic Type: Links aren't working on label using Dynamic Type

Project Member Reported by gambard@chromium.org, Oct 12 
The Dynamic Type font size displayed is slightly off compared to what is returned by font.fontSize (e.g. 13.5 vs 13). If the link is at the end of the text, the LabelLinkController can think that it is not inside the bounds of the Label and not put the tap target at all (so the link isn't working).

I think we should remove the link displayed inside the Label and replace them by making the whole cell tappable. WDYT?

Comment 1 by martijnb@chromium.org, Oct 15 

We discussed that it would be best to make the entire string/ cell in which a link exists, tappable.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af0578221d71ba1821da363a2390803977fb35c5

commit af0578221d71ba1821da363a2390803977fb35c5
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Oct 18 11:40:50 2018

[iOS] Migrate BandwidthManagement to UITableView

This CL migrates the BandwidthManagementCollectionViewController to a
UITableViewController base class.
It also creates the SettingsRootViewControlling protocol to allow easier
migration between the CollectionVC and the TableVC in settings.

Bug: 894791,  894837 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7710c43f38a65359743336745afd8510ed8f9591
Reviewed-on: https://chromium-review.googlesource.com/c/1277788
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600728}
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/BUILD.gn
[delete] https://crrev.com/a9fb0358c3b590e6841e9b4c8dc577f7b3739719/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.h
[delete] https://crrev.com/a9fb0358c3b590e6841e9b4c8dc577f7b3739719/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm
[add] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller.h
[add] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller.mm
[rename] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller_unittest.mm
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.h
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm
[add] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_view_controlling.h
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.mm
[modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm

Comment 3 by gambard@chromium.org, Oct 18

Status: Fixed (was: Assigned)
This can be mitigated by using UITextView instead.

Comment 4 by shbarezer@google.com, Oct 23

Status: Verified (was: Fixed)
Verified on 72.0.3585.0 Canary,  iPhoneX iOS 11.4.1

Very hard to notice the difference.
https://drive.google.com/file/d/1bwxVgKGaeb2v7iKoh2QJQ6mEIMAyAEXK/view
►

Sign in to add a comment