Compile failures on Windows x64 Debug GPU.FYI builder due to recent headless change |
|||
Issue descriptionFirst failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20x64%20Builder%20%28dbg%29/5748 Culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1263566 There was another follow-up fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1277992 But that didn't seem to fix the failure. Error text: ../../headless/lib/utility/headless_content_utility_client.cc(24,36): error: 'headless::HeadlessContentUtilityClient::SetNetworkBinderCreationCallbackForTests' redeclared without 'dllimport' attribute: 'dllexport' attribute added [-Werror,-Winconsistent-dllimport] void HeadlessContentUtilityClient::SetNetworkBinderCreationCallbackForTests( ^ ../..\headless/lib/utility/headless_content_utility_client.h(22,15): note: previous declaration is here static void SetNetworkBinderCreationCallbackForTests( ^ It's unclear why this is only failing on this bot. It doesn't seem to affect the other waterfalls. It doesn't seem to be affecting any CQs. Caseq can you try to fix this?
,
Oct 12
Reproduced locally, fix is coming RSN.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6161ec11189f8637ce020c9a09149f50a2c7ad6e commit 6161ec11189f8637ce020c9a09149f50a2c7ad6e Author: Wei Li <weili@chromium.org> Date: Fri Oct 12 19:40:50 2018 Fix headless component build on Windows In recent change crrev.com/c/1263566, HeadlessContentUtilityClient will be exported in component build on Windows. As usual, it should be exported in headless.dll. However, library headless_shell_lib also includes this class which results compilation errors. This CL excludes HeadlessContentUtilityClient from headless_shell_lib in component build to resolve the breakage. BUG= 894835 Change-Id: I44853a4c7a0701b9ea29cc16b18e9c3b358cb148 Reviewed-on: https://chromium-review.googlesource.com/c/1277883 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599324} [modify] https://crrev.com/6161ec11189f8637ce020c9a09149f50a2c7ad6e/headless/BUILD.gn
,
Oct 12
Issue 894681 has been merged into this issue.
,
Oct 12
GPU FYI Win x64 Builder is green again. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jmad...@chromium.org
, Oct 12