New issue
Advanced search Search tips

Issue 894821 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Androidx support for Chrome Custom Tabs

Reported by amr.fari...@gmail.com, Oct 12

Issue description

Application Version (from "Chrome Settings > About Chrome"): 69.0.3497.100
Android Build Number (from "Android Settings > About Phone/Tablet"): ONEPLUS A6003_22_180915
Device: OnePlus 6

Steps to reproduce: 

- Run an Android application that uses Androidx namespace
- Try to open a link with Chrome Custom Tabs SDK

Observed behavior: 

- Web link is opened using Google Chrome App

Expected behavior: 

- Custom Tab is opened within the original application

-------------------------------

I've had this issue on my personal device (OnePlus 6) and one multiple Android Emulators. Seems like the androidx namespace is not supported or not compatible with Chrome Custom Tabs Android SDK 

Frequency: 
<number of times you were able to reproduce> 

Additional comments: 

 
Components: UI>Browser>Mobile>CustomTabs
Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Labels: Target-72 M-72 Triaged-Mobile FoundIn-72 Pri-2 Type-Feature
Status: Untriaged (was: Unconfirmed)
This seems to be a feature request from above comment. Hence marking as Untriaged for further inputs from dev team.

Thanks!
Owner: peconn@chromium.org
Hey, can I get a few more details from you please?

How are you launching the Custom Tab? Something like this, or more involved (do you have your source code on github or something)?

String url = ¨https://paul.kinlan.me/¨;
CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
CustomTabsIntent customTabsIntent = builder.build();
customTabsIntent.launchUrl(this, Uri.parse(url));

And you're seeing the link just being opened in Chrome, instead of having a Chrome Custom Tab Activity open inside your app's Task?
Hey,

the link just opens in chrome. the intent is built exactly as you mentioned in your comment. Unfortunately, I don't have a repo to setup.

If you download the repo for this codelab https://codelabs.developers.google.com/codelabs/appauth-android-codelab/ and enable the Jetifier then you will see the issue.
Checked with a sample app on M70 and TOT - custom tabs do open. 
Did you replace com.android.support:customtabs with androidx.browser:browser:1.0.0 as per https://developer.android.com/jetpack/androidx/migrate ?
Labels: android-fe-triaged
Status: Unconfirmed (was: Untriaged)

Sign in to add a comment