New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment
link

Issue 894799: [Flaky] FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithout*

Reported by sheriff-...@appspot.gserviceaccount.com, Oct 12 Project Member

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of orphis@google.com

single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests
 

Comment 1 by bugdroid1@chromium.org, Oct 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70d0138d92d063b4d3032ffae54c950cf7c13f41

commit 70d0138d92d063b4d3032ffae54c950cf7c13f41
Author: Florent Castelli <orphis@chromium.org>
Date: Fri Oct 12 12:11:54 2018

Revert "Make DriveFS opt-out in FilesApp tests."

This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.

Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
Bug:  894799 

Original change's description:
> Make DriveFS opt-out in FilesApp tests.
> 
> Bug: 891197
> Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
> Reviewed-on: https://chromium-review.googlesource.com/c/1277133
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599117}

TBR=noel@chromium.org,sammc@chromium.org

Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891197
Reviewed-on: https://chromium-review.googlesource.com/c/1278757
Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599179}
[modify] https://crrev.com/70d0138d92d063b4d3032ffae54c950cf7c13f41/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/70d0138d92d063b4d3032ffae54c950cf7c13f41/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Comment 2 by dtapu...@chromium.org, Oct 15

Components: Platform>Apps>FileManager
Status: Untriaged (was: Available)

Comment 3 by cfroussios@chromium.org, Oct 16

Labels: -Sheriff-Chromium
Owner: sa...@chromium.org
Status: Assigned (was: Untriaged)
Removing from sheriff queue, since the failure doesn't occur anymore.

Assigning to author of reverted CL.

Comment 4 by sammc@google.com, Oct 16

Owner: lucmult@chromium.org

Comment 5 by lucmult@chromium.org, Oct 16

Status: Started (was: Assigned)
Thanks sammc@, I've CL to address this in review.

crrev.com/c/1278619

Comment 6 by bugdroid1@chromium.org, Oct 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f65bd26330cf709e4a4c4eb60876de5849f94d5

commit 6f65bd26330cf709e4a4c4eb60876de5849f94d5
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Oct 17 05:10:44 2018

Files app: Select My files when there are no volumes

Make Files app select "My files" when there are no available volumes,
this to allow Files app to behave properly when volumes subsequently
become available.

Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
non-null |displayRoot| before trying to change to |displayRoot|. This
fixes the error "Cannot read property 'getParent' of null" when Drive
volume becomes available before the (default) Downloads volume/root.

Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
DriveFsTestVolume can re-mount itself.

Changes since revert:
1. Add a new function |getVolumesCount| to return the number of volumes
available in the background page.
2. Add the new function above to wait for background page to have all
volumes before un-mounting and wait it to unmount all volumes.
3. Change some logs from error to warn because errors are expected and
handled when initializing volumes that are unmounting/unmounted in the
backend.
4. Change selector used to click on Drive to actually wait for
"My Drive" to be available.
5. A bit of more info in some logs around volume initialization.

Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
Bug: 893161,  884967 ,  894799 
Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
Reviewed-on: https://chromium-review.googlesource.com/c/1278619
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600282}
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/chromeos/components/drivefs/fake_drivefs.cc
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/ui/file_manager/file_manager/background/js/test_util_base.js
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/6f65bd26330cf709e4a4c4eb60876de5849f94d5/ui/file_manager/integration_tests/file_manager/file_display.js

Comment 7 by bugdroid1@chromium.org, Oct 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/103069350367d5c2cf85897e99e899b77a82f6b8

commit 103069350367d5c2cf85897e99e899b77a82f6b8
Author: Christos Froussios <cfroussios@chromium.org>
Date: Wed Oct 17 13:55:27 2018

Revert "Files app: Select My files when there are no volumes"

This reverts commit 6f65bd26330cf709e4a4c4eb60876de5849f94d5.

Reason for revert: Speculative revert
Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
on Linux ChromiumOS MSan

Note: resolved conflicts with ES6 refactoring, therefore running tests...

Bug:  896219 

Original change's description:
> Files app: Select My files when there are no volumes
>
> Make Files app select "My files" when there are no available volumes,
> this to allow Files app to behave properly when volumes subsequently
> become available.
>
> Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> non-null |displayRoot| before trying to change to |displayRoot|. This
> fixes the error "Cannot read property 'getParent' of null" when Drive
> volume becomes available before the (default) Downloads volume/root.
>
> Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> DriveFsTestVolume can re-mount itself.
>
> Changes since revert:
> 1. Add a new function |getVolumesCount| to return the number of volumes
> available in the background page.
> 2. Add the new function above to wait for background page to have all
> volumes before un-mounting and wait it to unmount all volumes.
> 3. Change some logs from error to warn because errors are expected and
> handled when initializing volumes that are unmounting/unmounted in the
> backend.
> 4. Change selector used to click on Drive to actually wait for
> "My Drive" to be available.
> 5. A bit of more info in some logs around volume initialization.
>
> Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> Bug: 893161,  884967 ,  894799 
> Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600282}

TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org

Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
Bug: 893161,  884967 ,  894799 
Reviewed-on: https://chromium-review.googlesource.com/c/1286146
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600376}
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/chromeos/components/drivefs/fake_drivefs.cc
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/ui/file_manager/file_manager/background/js/test_util_base.js
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/103069350367d5c2cf85897e99e899b77a82f6b8/ui/file_manager/integration_tests/file_manager/file_display.js

Comment 8 by bugdroid1@chromium.org, Oct 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/033dff086bc81067ff0a4f5dff54434b5293aa9a

commit 033dff086bc81067ff0a4f5dff54434b5293aa9a
Author: Christos Froussios <cfroussios@chromium.org>
Date: Wed Oct 17 16:52:42 2018

Reland "Files app: Select My files when there are no volumes"

This reverts commit 103069350367d5c2cf85897e99e899b77a82f6b8.

Reason for revert: Undoing speculative revert
The CL was not the culprit

Original change's description:
> Revert "Files app: Select My files when there are no volumes"
> 
> This reverts commit 6f65bd26330cf709e4a4c4eb60876de5849f94d5.
> 
> Reason for revert: Speculative revert
> Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
> on Linux ChromiumOS MSan
> 
> Note: resolved conflicts with ES6 refactoring, therefore running tests...
> 
> Bug:  896219 
> 
> Original change's description:
> > Files app: Select My files when there are no volumes
> >
> > Make Files app select "My files" when there are no available volumes,
> > this to allow Files app to behave properly when volumes subsequently
> > become available.
> >
> > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> > non-null |displayRoot| before trying to change to |displayRoot|. This
> > fixes the error "Cannot read property 'getParent' of null" when Drive
> > volume becomes available before the (default) Downloads volume/root.
> >
> > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> > DriveFsTestVolume can re-mount itself.
> >
> > Changes since revert:
> > 1. Add a new function |getVolumesCount| to return the number of volumes
> > available in the background page.
> > 2. Add the new function above to wait for background page to have all
> > volumes before un-mounting and wait it to unmount all volumes.
> > 3. Change some logs from error to warn because errors are expected and
> > handled when initializing volumes that are unmounting/unmounted in the
> > backend.
> > 4. Change selector used to click on Drive to actually wait for
> > "My Drive" to be available.
> > 5. A bit of more info in some logs around volume initialization.
> >
> > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> > Bug: 893161,  884967 ,  894799 
> > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> > Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> > Reviewed-by: Noel Gordon <noel@chromium.org>
> > Reviewed-by: Sam McNally <sammc@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600282}
> 
> TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org
> 
> Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
> Bug: 893161,  884967 ,  894799 
> Reviewed-on: https://chromium-review.googlesource.com/c/1286146
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600376}

TBR=noel@chromium.org,sammc@chromium.org,cfroussios@chromium.org,lucmult@chromium.org

Change-Id: I388a94fe12c7d40ac7ea779353c3b220bd5b5952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  896219 , 893161,  884967 ,  894799 
Reviewed-on: https://chromium-review.googlesource.com/c/1286853
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600429}
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/chromeos/components/drivefs/fake_drivefs.cc
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/ui/file_manager/file_manager/background/js/test_util_base.js
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/033dff086bc81067ff0a4f5dff54434b5293aa9a/ui/file_manager/integration_tests/file_manager/file_display.js

Comment 9 by lucmult@chromium.org, Oct 17

Cc: noel@chromium.org
Summary: [Flaky] FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithout* (was: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests)
I'm checking the flakiness dashboard and this is still a bit flaky:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fileDisplayWithout

A sample failure that I found on:
FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumes

[ RUN      ] FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumes
[18092:18092:1017/101811.160461:INFO:easy_unlock_service_regular.cc(163)] DeviceSyncClient is not ready yet, delaying UseLoadedRemoteDevices().
[18092:18092:1017/101811.296995:INFO:secure_channel_service.cc(25)] SecureChannelService::OnStart()
[18092:18092:1017/101811.299502:INFO:secure_channel_initializer.cc(64)] SecureChannelInitializer::SecureChannelInitializer(): Fetching Bluetooth adapter. All requests received before the adapter is fetched will be queued.
[18092:18092:1017/101811.299547:INFO:secure_channel_service.cc(38)] SecureChannelService::OnBindInterface() for interface chromeos.secure_channel.mojom.SecureChannel.
[18092:18092:1017/101811.299620:INFO:device_sync_service.cc(30)] DeviceSyncService::OnStart()
[18092:18092:1017/101811.299647:INFO:device_sync_service.cc(46)] DeviceSyncService::OnBindInterface() from interface chromeos.device_sync.mojom.DeviceSync.
[18092:18092:1017/101811.299711:INFO:multidevice_setup_service.cc(60)] MultiDeviceSetupService::OnStart()
[18092:18092:1017/101811.299739:INFO:multidevice_setup_service.cc(73)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[18092:18092:1017/101811.304693:INFO:secure_channel_initializer.cc(119)] SecureChannelInitializer::OnBluetoothAdapterReceived(): Bluetooth adapter has been fetched. Passing all queued requests to the service.
[18092:18092:1017/101811.305177:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[18092:18092:1017/101811.316930:INFO:multidevice_setup_service.cc(73)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[18092:18092:1017/101811.380620:INFO:file_manager_browsertest_base.cc(1148)] FileManagerBrowserTest::StartTest fileDisplayWithoutVolumes
[18092:18092:1017/101811.993249:INFO:CONSOLE(720)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (720)
[18092:18092:1017/101811.994501:INFO:CONSOLE(5540)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5540)
[18092:18092:1017/101812.015686:INFO:CONSOLE(5542)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5542)
[18092:18092:1017/101812.015725:INFO:CONSOLE(5552)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5552)
[18092:18092:1017/101812.015739:INFO:CONSOLE(6005)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6005)
[18092:18092:1017/101812.015852:INFO:CONSOLE(5552)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5552)
[18092:18092:1017/101812.015868:INFO:CONSOLE(6005)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6005)
[18092:18092:1017/101812.015917:INFO:CONSOLE(5552)] "Initializing volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5552)
[18092:18092:1017/101812.015930:INFO:CONSOLE(6005)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6005)
[18092:18092:1017/101812.022308:INFO:CONSOLE(64)] "[unhandled-error]: Failed to mount a file system: android_files:AndroidFiles because of: Volume not found.
Error: original stack
    at console.error.args [as error] (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:61:19)
    at chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:6087:17", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (64)
[18092:18092:1017/101812.022345:INFO:CONSOLE(5556)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5556)
[18092:18092:1017/101812.022368:INFO:CONSOLE(64)] "[unhandled-error]: Failed to mount a file system: downloads:Downloads because of: Volume not found.
Error: original stack
    at console.error.args [as error] (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:61:19)
    at chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:6087:17", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (64)
[18092:18092:1017/101812.022380:INFO:CONSOLE(5556)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5556)
[18092:18092:1017/101812.022401:INFO:CONSOLE(64)] "[unhandled-error]: Failed to mount a file system: drive:v2 because of: Volume not found.
Error: original stack
    at console.error.args [as error] (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:61:19)
    at chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:6087:17", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (64)
[18092:18092:1017/101812.022412:INFO:CONSOLE(5556)] "Initialized volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5556)
[18092:18092:1017/101812.022422:INFO:CONSOLE(5560)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5560)
[18092:18092:1017/101812.022446:INFO:CONSOLE(5619)] "Unmounted volume without a request: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5619)
[18092:18092:1017/101812.028060:INFO:CONSOLE(4942)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4942)
[18092:18092:1017/101812.065247:INFO:CONSOLE(4939)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4939)
[18092:18092:1017/101812.065309:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
[18092:18092:1017/101812.075268:INFO:CONSOLE(0)] ":unresolved pseudo selector is deprecated and will be removed in M73, around March 2019. Please use :not(:defined) instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source:  (0)
[18092:18092:1017/101812.097202:INFO:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442)
[18092:18092:1017/101812.284771:INFO:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083)
[18092:18092:1017/101812.429444:INFO:CONSOLE(51973)] "Unexpectedly failed to obtain the default display root.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (51973)
[18092:18092:1017/101812.527152:INFO:CONSOLE(0)] "[FAIL] [fileDisplayWithoutVolumes]: API Test Error in [fileDisplayWithoutVolumes]: The error count is not 0.
Actual: 3
Expected: 0
Error
    at extensions::test:243:18
    at chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js:56:17", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[18092:18092:1017/101812.527379:INFO:CONSOLE(0)] "Uncaught (in promise) chrome.test.failure", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:1175: Failure
Failed

Comment 10 by lucmult@chromium.org, Oct 18

Labels: OS-Chrome
Status: Fixed (was: Started)
Oh this failure was exactly before my latest fix.

The failure pointed there, has been converted to console.warn():
"[unhandled-error]: Failed to mount a file system: drive:v2 because of: Volume not found.

https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/background/js/volume_manager_util.js?l=179&rcl=e69c2df482984e823c5731f22e71bec39b539cef
 console.warn('Failed to mount a file system: ' +


So, this looks good so far, I'm closing this bug.

Comment 11 by bugdroid1@chromium.org, Oct 18

Project Member
Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/512139f8a5dfba65abc441b55973e1659eafcf87

commit 512139f8a5dfba65abc441b55973e1659eafcf87
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Oct 18 22:49:40 2018

Reland "Files app: Select My files when there are no volumes"

This reverts commit 103069350367d5c2cf85897e99e899b77a82f6b8.

Reason for revert: Undoing speculative revert
The CL was not the culprit

Original change's description:
> Revert "Files app: Select My files when there are no volumes"
>
> This reverts commit 6f65bd26330cf709e4a4c4eb60876de5849f94d5.
>
> Reason for revert: Speculative revert
> Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
> on Linux ChromiumOS MSan
>
> Note: resolved conflicts with ES6 refactoring, therefore running tests...
>
> Bug:  896219 
>
> Original change's description:
> > Files app: Select My files when there are no volumes
> >
> > Make Files app select "My files" when there are no available volumes,
> > this to allow Files app to behave properly when volumes subsequently
> > become available.
> >
> > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> > non-null |displayRoot| before trying to change to |displayRoot|. This
> > fixes the error "Cannot read property 'getParent' of null" when Drive
> > volume becomes available before the (default) Downloads volume/root.
> >
> > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> > DriveFsTestVolume can re-mount itself.
> >
> > Changes since revert:
> > 1. Add a new function |getVolumesCount| to return the number of volumes
> > available in the background page.
> > 2. Add the new function above to wait for background page to have all
> > volumes before un-mounting and wait it to unmount all volumes.
> > 3. Change some logs from error to warn because errors are expected and
> > handled when initializing volumes that are unmounting/unmounted in the
> > backend.
> > 4. Change selector used to click on Drive to actually wait for
> > "My Drive" to be available.
> > 5. A bit of more info in some logs around volume initialization.
> >
> > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> > Bug: 893161,  884967 ,  894799 
> > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> > Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> > Reviewed-by: Noel Gordon <noel@chromium.org>
> > Reviewed-by: Sam McNally <sammc@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600282}
>
> TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org
>
> Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
> Bug: 893161,  884967 ,  894799 
> Reviewed-on: https://chromium-review.googlesource.com/c/1286146
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600376}

TBR=noel@chromium.org,sammc@chromium.org,cfroussios@chromium.org,lucmult@chromium.org

Change-Id: I388a94fe12c7d40ac7ea779353c3b220bd5b5952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  896219 , 893161,  884967 ,  894799 
Reviewed-on: https://chromium-review.googlesource.com/c/1286853
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600429}
Reviewed-on: https://chromium-review.googlesource.com/c/1287350
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#136}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/512139f8a5dfba65abc441b55973e1659eafcf87/ui/file_manager/file_manager/background/js/test_util_base.js
[modify] https://crrev.com/512139f8a5dfba65abc441b55973e1659eafcf87/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/512139f8a5dfba65abc441b55973e1659eafcf87/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/512139f8a5dfba65abc441b55973e1659eafcf87/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/512139f8a5dfba65abc441b55973e1659eafcf87/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/512139f8a5dfba65abc441b55973e1659eafcf87/ui/file_manager/integration_tests/file_manager/file_display.js

Comment 12 by cr-audit...@appspot.gserviceaccount.com, Oct 23

Project Member
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/512139f8a5dfba65abc441b55973e1659eafcf87

Commit: 512139f8a5dfba65abc441b55973e1659eafcf87
Author: lucmult@chromium.org
Commiter: lucmult@chromium.org
Date: 2018-10-18 22:49:40 +0000 UTC

Reland "Files app: Select My files when there are no volumes"

This reverts commit 103069350367d5c2cf85897e99e899b77a82f6b8.

Reason for revert: Undoing speculative revert
The CL was not the culprit

Original change's description:
> Revert "Files app: Select My files when there are no volumes"
>
> This reverts commit 6f65bd26330cf709e4a4c4eb60876de5849f94d5.
>
> Reason for revert: Speculative revert
> Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
> on Linux ChromiumOS MSan
>
> Note: resolved conflicts with ES6 refactoring, therefore running tests...
>
> Bug:  896219 
>
> Original change's description:
> > Files app: Select My files when there are no volumes
> >
> > Make Files app select "My files" when there are no available volumes,
> > this to allow Files app to behave properly when volumes subsequently
> > become available.
> >
> > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> > non-null |displayRoot| before trying to change to |displayRoot|. This
> > fixes the error "Cannot read property 'getParent' of null" when Drive
> > volume becomes available before the (default) Downloads volume/root.
> >
> > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> > DriveFsTestVolume can re-mount itself.
> >
> > Changes since revert:
> > 1. Add a new function |getVolumesCount| to return the number of volumes
> > available in the background page.
> > 2. Add the new function above to wait for background page to have all
> > volumes before un-mounting and wait it to unmount all volumes.
> > 3. Change some logs from error to warn because errors are expected and
> > handled when initializing volumes that are unmounting/unmounted in the
> > backend.
> > 4. Change selector used to click on Drive to actually wait for
> > "My Drive" to be available.
> > 5. A bit of more info in some logs around volume initialization.
> >
> > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> > Bug: 893161,  884967 ,  894799 
> > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> > Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> > Reviewed-by: Noel Gordon <noel@chromium.org>
> > Reviewed-by: Sam McNally <sammc@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600282}
>
> TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org
>
> Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
> Bug: 893161,  884967 ,  894799 
> Reviewed-on: https://chromium-review.googlesource.com/c/1286146
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600376}

TBR=noel@chromium.org,sammc@chromium.org,cfroussios@chromium.org,lucmult@chromium.org

Change-Id: I388a94fe12c7d40ac7ea779353c3b220bd5b5952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  896219 , 893161,  884967 ,  894799 
Reviewed-on: https://chromium-review.googlesource.com/c/1286853
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600429}
Reviewed-on: https://chromium-review.googlesource.com/c/1287350
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#136}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment